[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <202211281840.LRFM8If6-lkp@intel.com>
Date: Mon, 28 Nov 2022 18:44:37 +0800
From: kernel test robot <lkp@...el.com>
To: qixiaoyu1 <qxy65535@...il.com>, Jaegeuk Kim <jaegeuk@...nel.org>,
Chao Yu <yuchao0@...wei.com>, Chao Yu <chao@...nel.org>
Cc: oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
linux-f2fs-devel@...ts.sourceforge.net,
qixiaoyu1 <qixiaoyu1@...omi.com>,
xiongping1 <xiongping1@...omi.com>
Subject: Re: [PATCH 2/5] f2fs: implement cache to manager block update
frequency per inode
Hi qixiaoyu1,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on v6.1-rc7]
[also build test WARNING on linus/master next-20221128]
[cannot apply to jaegeuk-f2fs/dev-test jaegeuk-f2fs/dev]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/qixiaoyu1/Support-enhanced-hot-cold-data-separation-for-f2fs/20221128-170808
patch link: https://lore.kernel.org/r/20221128085859.5295-3-qixiaoyu1%40xiaomi.com
patch subject: [PATCH 2/5] f2fs: implement cache to manager block update frequency per inode
config: loongarch-allyesconfig
compiler: loongarch64-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/6cb3793893a42780f6e596d7f694160179e724f5
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review qixiaoyu1/Support-enhanced-hot-cold-data-separation-for-f2fs/20221128-170808
git checkout 6cb3793893a42780f6e596d7f694160179e724f5
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=loongarch SHELL=/bin/bash fs/f2fs/
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>
All warnings (new ones prefixed by >>):
In file included from include/trace/define_trace.h:102,
from include/trace/events/f2fs.h:2404,
from fs/f2fs/super.c:40:
include/trace/events/f2fs.h: In function 'trace_raw_output_f2fs_add_age_extent_node':
>> include/trace/events/f2fs.h:1695:19: warning: format '%lu' expects argument of type 'long unsigned int', but argument 6 has type 'unsigned int' [-Wformat=]
1695 | TP_printk("dev = (%d,%d), ino = %lu, node_cnt = %lu, "
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/trace/trace_events.h:203:34: note: in definition of macro 'DECLARE_EVENT_CLASS'
203 | trace_event_printf(iter, print); \
| ^~~~~
include/trace/events/f2fs.h:1695:9: note: in expansion of macro 'TP_printk'
1695 | TP_printk("dev = (%d,%d), ino = %lu, node_cnt = %lu, "
| ^~~~~~~~~
In file included from include/trace/trace_events.h:237:
include/trace/events/f2fs.h:1695:59: note: format string is defined here
1695 | TP_printk("dev = (%d,%d), ino = %lu, node_cnt = %lu, "
| ~~^
| |
| long unsigned int
| %u
vim +1695 include/trace/events/f2fs.h
1669
1670 TP_PROTO(struct f2fs_sb_info *sbi,
1671 struct age_extent_tree *et, struct age_extent_info *ei),
1672
1673 TP_ARGS(sbi, et, ei),
1674
1675 TP_STRUCT__entry(
1676 __field(dev_t, dev)
1677 __field(ino_t, ino)
1678 __field(unsigned int, cnt)
1679 __field(unsigned int, fofs)
1680 __field(unsigned int, len)
1681 __field(unsigned long long, age)
1682 __field(unsigned long long, blocks)
1683 ),
1684
1685 TP_fast_assign(
1686 __entry->dev = sbi->sb->s_dev;
1687 __entry->ino = et->ino;
1688 __entry->cnt = atomic_read(&et->node_cnt);
1689 __entry->fofs = ei->fofs;
1690 __entry->len = ei->len;
1691 __entry->age = ei->age;
1692 __entry->blocks = ei->last_blocks;
1693 ),
1694
> 1695 TP_printk("dev = (%d,%d), ino = %lu, node_cnt = %lu, "
1696 "age_ext_info(fofs: %u, len: %u, age: %llu, blocks: %llu)",
1697 show_dev_ino(__entry),
1698 __entry->cnt,
1699 __entry->fofs,
1700 __entry->len,
1701 __entry->age,
1702 __entry->blocks)
1703 );
1704
--
0-DAY CI Kernel Test Service
https://01.org/lkp
View attachment "config" of type "text/plain" (327715 bytes)
Powered by blists - more mailing lists