linux-kernel - Re: [PATCH 4/5] f2fs: update block age info during out of place update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 28 Nov 2022 19:14:57 +0800
From:   kernel test robot <lkp@...el.com>
To:     qixiaoyu1 <qxy65535@...il.com>, Jaegeuk Kim <jaegeuk@...nel.org>,
        Chao Yu <yuchao0@...wei.com>, Chao Yu <chao@...nel.org>
Cc:     oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
        linux-f2fs-devel@...ts.sourceforge.net,
        qixiaoyu1 <qixiaoyu1@...omi.com>,
        xiongping1 <xiongping1@...omi.com>
Subject: Re: [PATCH 4/5] f2fs: update block age info during out of place
 update

Hi qixiaoyu1,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on v6.1-rc7]
[also build test WARNING on linus/master next-20221128]
[cannot apply to jaegeuk-f2fs/dev-test jaegeuk-f2fs/dev]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/qixiaoyu1/Support-enhanced-hot-cold-data-separation-for-f2fs/20221128-170808
patch link:    https://lore.kernel.org/r/20221128085859.5295-5-qixiaoyu1%40xiaomi.com
patch subject: [PATCH 4/5] f2fs: update block age info during out of place update
config: sparc-allyesconfig
compiler: sparc64-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/0ac666d056ce1e58a5ffea1fe153c413dd8b7148
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review qixiaoyu1/Support-enhanced-hot-cold-data-separation-for-f2fs/20221128-170808
        git checkout 0ac666d056ce1e58a5ffea1fe153c413dd8b7148
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=sparc SHELL=/bin/bash fs/f2fs/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> fs/f2fs/block_age.c:505:20: warning: no previous prototype for 'f2fs_get_cur_dblock_allocated' [-Wmissing-prototypes]
     505 | unsigned long long f2fs_get_cur_dblock_allocated(struct f2fs_sb_info *sbi)
         |                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~


vim +/f2fs_get_cur_dblock_allocated +505 fs/f2fs/block_age.c

   504	
 > 505	unsigned long long f2fs_get_cur_dblock_allocated(struct f2fs_sb_info *sbi)
   506	{
   507		return atomic64_read(&sbi->total_data_alloc);
   508	}
   509	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (322336 bytes)