linux-kernel - Re: [PATCH v8 4/4] hwmon: (max6639) Add pwm support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d2d54a34-56dc-df83-5fde-ad0a9a73a9e0@roeck-us.net>
Date:   Tue, 29 Nov 2022 08:41:12 -0800
From:   Guenter Roeck <linux@...ck-us.net>
To:     Uwe Kleine-König <u.kleine-koenig@...gutronix.de>,
        Naresh Solanki <naresh.solanki@...ements.com>
Cc:     devicetree@...r.kernel.org, Jean Delvare <jdelvare@...e.com>,
        Thierry Reding <thierry.reding@...il.com>,
        linux-kernel@...r.kernel.org, linux-hwmon@...r.kernel.org,
        Patrick Rudolph <patrick.rudolph@...ements.com>,
        linux-pwm@...r.kernel.org, kernel@...gutronix.de
Subject: Re: [PATCH v8 4/4] hwmon: (max6639) Add pwm support

On 11/29/22 08:34, Uwe Kleine-König wrote:
> On Tue, Nov 29, 2022 at 05:11:34PM +0100, Naresh Solanki wrote:
>> Add pwm support for max6639. Also configure pwm fan speed based on pwm
>> provided in DT.
> 
> Did you do anything to resolve the questions I had in reply to v5? If
> yes, I must have missed it.
> 

I don't see a response to my concerns either, especially regarding fan mode
(dc vs. pwm) in the bindings. For that reason, I won't even look at the series.

Guenter

> Note that maintainer time is scarce and with sending new versions of a
> patch with no sign that you improved in the aspects that were critized
> before, you're burning that scarce time and loosing the good will of the
> responsible maintainers.
> 
> Best regards
> Uwe
>