[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Y4ZP+0koq0xIm4H9@lunn.ch>
Date: Tue, 29 Nov 2022 19:31:23 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc: Chukun Pan <amadeus@....edu.cn>,
"David S . Miller" <davem@...emloft.net>,
Giuseppe Cavallaro <peppe.cavallaro@...com>,
Alexandre Torgue <alexandre.torgue@...s.st.com>,
Jose Abreu <joabreu@...opsys.com>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>,
David Wu <david.wu@...k-chips.com>,
Rob Herring <robh+dt@...nel.org>,
Heiko Stuebner <heiko@...ech.de>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
netdev@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 2/2] ethernet: stmicro: stmmac: Add SGMII/QSGMII support
for RK3568
> > -static int phy_power_on(struct rk_priv_data *bsp_priv, bool enable)
> > +static int rk_gmac_phy_power_on(struct rk_priv_data *bsp_priv, bool enable)
> > {
> > struct regulator *ldo = bsp_priv->regulator;
> > int ret;
> > @@ -1728,6 +1909,18 @@ static struct rk_priv_data *rk_gmac_setup(struct platform_device *pdev,
> > "rockchip,grf");
> > bsp_priv->php_grf = syscon_regmap_lookup_by_phandle(dev->of_node,
> > "rockchip,php-grf");
> > + bsp_priv->xpcs = syscon_regmap_lookup_by_phandle(dev->of_node,
> > + "rockchip,xpcs");
> > + if (!IS_ERR(bsp_priv->xpcs)) {
> > + struct phy *comphy;
> > +
> > + comphy = devm_of_phy_get(&pdev->dev, dev->of_node, NULL);
>
> So instead of having PHY driver, you added a syscon and implemented PHY
> driver here. No. Make a proper PHY driver.
I'm also thinking there should be a proper pcs driver in drivers/net/pcs.
Andrew
Powered by blists - more mailing lists