linux-kernel - Re: [RESEND PATCH 2/2] arm64: dts: qcom: sdm632-fairphone-fp3: Add NFC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 29 Nov 2022 19:31:47 +0100
From:   Luca Weiss <luca@...tu.xyz>
To:     linux-arm-msm@...r.kernel.org,
        Konrad Dybcio <konrad.dybcio@...aro.org>
Cc:     ~postmarketos/upstreaming@...ts.sr.ht, phone-devel@...r.kernel.org,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [RESEND PATCH 2/2] arm64: dts: qcom: sdm632-fairphone-fp3: Add NFC

On Dienstag, 29. November 2022 14:29:36 CET Konrad Dybcio wrote:
> On 28.11.2022 18:37, Luca Weiss wrote:
> > Configure the node for the NQ310 chip found on this device, which is
> > compatible with generic nxp-nci-i2c driver.
> > 
> > Signed-off-by: Luca Weiss <luca@...tu.xyz>
> > ---
> > RESEND to fix Cc
> > 
> >  arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts | 15 +++++++++++++++
> >  1 file changed, 15 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts
> > b/arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts index
> > 2920504461d3..fde93cbcd180 100644
> > --- a/arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts
> > +++ b/arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts
> > @@ -63,6 +63,21 @@ touchscreen@48 {
> > 
> >  	};
> >  
> >  };
> > 
> > +&i2c_5 {
> > +	status = "okay";
> > +
> > +	nfc@28 {
> > +		compatible = "nxp,nq310", "nxp,nxp-nci-i2c";
> 
> Unless there was some binding change (that was not emailed to me with
> this email, I only got 2/2), only "nxp,nxp-nci-i2c" and
> "nxp,pn547", "nxp,nxp-nci-i2c" are allowed.

Yes, I've added the double compatible to the yaml.
https://lore.kernel.org/lkml/20221128173744.833018-1-luca@z3ntu.xyz/

I'll try to work on my Cc-script setup, currently it adds the output of 
get_maintainers.pl for each patch (and adds all for the cover letter), which 
is based on some script I found a while ago online.

Is there like a recommended way to put all people in Cc for a series, I'm not 
aware of anything at least...

Perhaps I'll look into b4 for sending patches, that seems to have some goodies 
there.

Regards
Luca

> 
> The node looks good though.
> 
> Konrad
> 
> > +		reg = <0x28>;
> > +
> > +		interrupt-parent = <&tlmm>;
> > +		interrupts = <17 IRQ_TYPE_LEVEL_HIGH>;
> > +
> > +		enable-gpios = <&tlmm 16 GPIO_ACTIVE_HIGH>;
> > +		firmware-gpios = <&tlmm 62 GPIO_ACTIVE_HIGH>;
> > +	};
> > +};
> > +
> > 
> >  &pm8953_resin {
> >  
> >  	status = "okay";
> >  	linux,code = <KEY_VOLUMEDOWN>;