[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20221129183356.bdlhgset4rk5a5kp@skbuf>
Date: Tue, 29 Nov 2022 20:33:56 +0200
From: Vladimir Oltean <vladimir.oltean@....com>
To: Andrew Lunn <andrew@...n.ch>
Cc: yang.yang29@....com.cn, peppe.cavallaro@...com,
alexandre.torgue@...s.st.com, joabreu@...opsys.com,
davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
pabeni@...hat.com, mcoquelin.stm32@...il.com,
netdev@...r.kernel.org, linux-stm32@...md-mailman.stormreply.com,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
xu.panda@....com.cn
Subject: Re: [PATCH linux-next v2] net: stmmac: use sysfs_streq() instead of
strncmp()
On Tue, Nov 29, 2022 at 07:25:41PM +0100, Andrew Lunn wrote:
> > With strncmp("tc:", 3), the code matches on the "tc:1" token properly.
> > With sysfs_streq("tc:"), it doesn't.
>
> It is not clear you have addressed this point.
As they say, "let sleeping dogs cry". I'm not sure that we should be
making (especially untested) changes in the cmdline handling there.
Powered by blists - more mailing lists