linux-kernel - Re: [net-next PATCH V2 3/4] octeontx2-pf: ethtool: Implement get_fec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y4ZTSh7/xCJVosyW@lunn.ch>
Date:   Tue, 29 Nov 2022 19:45:30 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Hariprasad Kelam <hkelam@...vell.com>
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        kuba@...nel.org, davem@...emloft.net, pabeni@...hat.com,
        edumazet@...gle.com, sgoutham@...vell.com, lcherian@...vell.com,
        gakula@...vell.com, jerinj@...vell.com, sbhatta@...vell.com
Subject: Re: [net-next PATCH V2 3/4] octeontx2-pf: ethtool: Implement
 get_fec_stats

On Tue, Nov 29, 2022 at 10:44:08AM +0530, Hariprasad Kelam wrote:
> The current implementation is such that FEC statistics are reported as
> part of ethtool statistics that is the user can fetch them from the
> below command
> 
> "ethtool -S eth0"
> 
> Fec Corrected Errors:
> Fec Uncorrected Errors:
> 
> This patch removes this logic

What might break the ABI, if anybody is using these statistics, or has
a dumb parser and just looks at entry 42 which is now a different
entry.

So i think you need to keep these two, and additionally report them
the correct way via get_fec_stats.

    Andrew