linux-kernel - Re: [PATCH net-next] net: devlink: add DEVLINK_INFO_VERSION_GENERIC_FW

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMZ6RqLQe41eHuZNLZEP93ER-xvfKzK9V8EV1zXfmyKaf_a0aQ@mail.gmail.com>
Date:   Tue, 29 Nov 2022 12:08:49 +0900
From:   Vincent MAILHOL <mailhol.vincent@...adoo.fr>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     Jiri Pirko <jiri@...dia.com>,
        "David S . Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, Andrew Lunn <andrew@...n.ch>,
        Marc Kleine-Budde <mkl@...gutronix.de>,
        linux-can <linux-can@...r.kernel.org>
Subject: Re: [PATCH net-next] net: devlink: add DEVLINK_INFO_VERSION_GENERIC_FW_BOOTLOADER

+CC: Marc and linux-can mailing list.

On Tue. 29 Nov. 2022 at 11:14, Jakub Kicinski <kuba@...nel.org> wrote:
> On Tue, 29 Nov 2022 11:01:51 +0900 Vincent Mailhol wrote:
> > As discussed in [1], abbreviating the bootloader to "bl" might not be
> > well understood. Instead, a bootloader technically being a firmware,
> > name it "fw.bootloader".
> >
> > Add a new macro to devlink.h to formalize this new info attribute
> > name.
> >
> > [1] https://lore.kernel.org/netdev/20221128142723.2f826d20@kernel.org/
> >
> > Suggested-by: Jakub Kicinski <kuba@...nel.org>
> > Signed-off-by: Vincent Mailhol <mailhol.vincent@...adoo.fr>
>
> It's okay for this patch to go via the can tree, FWIW.
> It may cause an extra delay for you if you have to wait
> for the define to propagate.

Marc always pulls from net-next before picking patches and it is a
common practice to send to the linux-can mailing list some series
which are based on net-next. So I do not foresee any major delay.

> Either way you should document the meaning of the parameter,
> however obvious it may seem:
>
>  Documentation/networking/devlink/devlink-info.rst

ACK.

I will send the v2 with both the netdev and the linux-can mailing
list. I am fine whoever picks it.