linux-kernel - Re: [PATCH net-next] net: devlink: add DEVLINK_INFO_VERSION_GENERIC_FW

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221128181430.2390b238@kernel.org>
Date:   Mon, 28 Nov 2022 18:14:30 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Vincent Mailhol <mailhol.vincent@...adoo.fr>
Cc:     Jiri Pirko <jiri@...dia.com>,
        "David S . Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, Andrew Lunn <andrew@...n.ch>
Subject: Re: [PATCH net-next] net: devlink: add
 DEVLINK_INFO_VERSION_GENERIC_FW_BOOTLOADER

On Tue, 29 Nov 2022 11:01:51 +0900 Vincent Mailhol wrote:
> As discussed in [1], abbreviating the bootloader to "bl" might not be
> well understood. Instead, a bootloader technically being a firmware,
> name it "fw.bootloader".
> 
> Add a new macro to devlink.h to formalize this new info attribute
> name.
> 
> [1] https://lore.kernel.org/netdev/20221128142723.2f826d20@kernel.org/
> 
> Suggested-by: Jakub Kicinski <kuba@...nel.org>
> Signed-off-by: Vincent Mailhol <mailhol.vincent@...adoo.fr>

It's okay for this patch to go via the can tree, FWIW.
It may cause an extra delay for you if you have to wait
for the define to propagate.

Either way you should document the meaning of the parameter, 
however obvious it may seem:

 Documentation/networking/devlink/devlink-info.rst