linux-kernel - RE: [Intel-wired-lan] [PATCH net-next v5 3/4] net: devlink: make the devlink_ops::info

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Tue, 29 Nov 2022 00:24:18 +0000
From:   "Keller, Jacob E" <jacob.e.keller@...el.com>
To:     Vincent Mailhol <mailhol.vincent@...adoo.fr>,
        Jiri Pirko <jiri@...dia.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "Jakub Kicinski" <kuba@...nel.org>
CC:     Andrew Lunn <andrew@...n.ch>,
        Shijith Thotton <sthotton@...vell.com>,
        Simon Horman <simon.horman@...igine.com>,
        Kurt Kanzenbach <kurt@...utronix.de>,
        Eric Dumazet <edumazet@...gle.com>,
        Jerin Jacob <jerinj@...vell.com>,
        Subbaraya Sundeep <sbhatta@...vell.com>,
        Ioana Ciornei <ioana.ciornei@....com>,
        "drivers@...sando.io" <drivers@...sando.io>,
        "Linu Cherian" <lcherian@...vell.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        Leon Romanovsky <leon@...nel.org>,
        "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
        Shalom Toledo <shalomt@...lanox.com>,
        Srujana Challa <schalla@...vell.com>,
        Minghao Chi <chi.minghao@....com.cn>,
        Hao Chen <chenhao288@...ilicon.com>,
        Guangbin Huang <huangguangbin2@...wei.com>,
        Shannon Nelson <snelson@...sando.io>,
        "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
        "Vadim Fedorenko" <vadfed@...com>, Paolo Abeni <pabeni@...hat.com>,
        Yisen Zhuang <yisen.zhuang@...wei.com>,
        Sunil Goutham <sgoutham@...vell.com>,
        Ariel Elior <aelior@...vell.com>,
        Ido Schimmel <idosch@...dia.com>,
        Richard Cochran <richardcochran@...il.com>,
        Arnaud Ebalard <arno@...isbad.org>,
        Jiri Pirko <jiri@...lanox.com>,
        Michael Chan <michael.chan@...adcom.com>,
        Petr Machata <petrm@...dia.com>,
        Salil Mehta <salil.mehta@...wei.com>,
        "Dimitris Michailidis" <dmichail@...gible.com>,
        Manish Chopra <manishc@...vell.com>,
        Boris Brezillon <bbrezillon@...nel.org>,
        "oss-drivers@...igine.com" <oss-drivers@...igine.com>,
        Vadim Pasternak <vadimp@...lanox.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "David S . Miller" <davem@...emloft.net>,
        Taras Chornyi <tchornyi@...vell.com>,
        hariprasad <hkelam@...vell.com>,
        "linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>,
        Jonathan Lemon <jonathan.lemon@...il.com>,
        Vladimir Oltean <olteanv@...il.com>,
        Saeed Mahameed <saeedm@...dia.com>,
        Geetha sowjanya <gakula@...vell.com>
Subject: RE: [Intel-wired-lan] [PATCH net-next v5 3/4] net: devlink: make the
 devlink_ops::info_get() callback optional



> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of
> Vincent Mailhol
> Sent: Monday, November 28, 2022 4:06 PM
> To: Jiri Pirko <jiri@...dia.com>; netdev@...r.kernel.org; Jakub Kicinski
> <kuba@...nel.org>
> Cc: Andrew Lunn <andrew@...n.ch>; Shijith Thotton <sthotton@...vell.com>;
> Simon Horman <simon.horman@...igine.com>; Kurt Kanzenbach
> <kurt@...utronix.de>; Eric Dumazet <edumazet@...gle.com>; Jerin Jacob
> <jerinj@...vell.com>; Subbaraya Sundeep <sbhatta@...vell.com>; Ioana
> Ciornei <ioana.ciornei@....com>; drivers@...sando.io; Linu Cherian
> <lcherian@...vell.com>; Florian Fainelli <f.fainelli@...il.com>; Herbert Xu
> <herbert@...dor.apana.org.au>; Leon Romanovsky <leon@...nel.org>; linux-
> rdma@...r.kernel.org; Shalom Toledo <shalomt@...lanox.com>; Srujana
> Challa <schalla@...vell.com>; Minghao Chi <chi.minghao@....com.cn>; Hao
> Chen <chenhao288@...ilicon.com>; Guangbin Huang
> <huangguangbin2@...wei.com>; Shannon Nelson <snelson@...sando.io>;
> intel-wired-lan@...ts.osuosl.org; Vadim Fedorenko <vadfed@...com>; Paolo
> Abeni <pabeni@...hat.com>; Yisen Zhuang <yisen.zhuang@...wei.com>; Sunil
> Goutham <sgoutham@...vell.com>; Ariel Elior <aelior@...vell.com>; Ido
> Schimmel <idosch@...dia.com>; Richard Cochran <richardcochran@...il.com>;
> Arnaud Ebalard <arno@...isbad.org>; Jiri Pirko <jiri@...lanox.com>; Michael
> Chan <michael.chan@...adcom.com>; Vincent Mailhol
> <mailhol.vincent@...adoo.fr>; Petr Machata <petrm@...dia.com>; Salil Mehta
> <salil.mehta@...wei.com>; Dimitris Michailidis <dmichail@...gible.com>;
> Manish Chopra <manishc@...vell.com>; Boris Brezillon
> <bbrezillon@...nel.org>; oss-drivers@...igine.com; Vadim Pasternak
> <vadimp@...lanox.com>; linux-kernel@...r.kernel.org; David S . Miller
> <davem@...emloft.net>; Taras Chornyi <tchornyi@...vell.com>; hariprasad
> <hkelam@...vell.com>; linux-crypto@...r.kernel.org; Jonathan Lemon
> <jonathan.lemon@...il.com>; Vladimir Oltean <olteanv@...il.com>; Saeed
> Mahameed <saeedm@...dia.com>; Geetha sowjanya <gakula@...vell.com>
> Subject: [Intel-wired-lan] [PATCH net-next v5 3/4] net: devlink: make the
> devlink_ops::info_get() callback optional
> 
> Some drivers only reported the driver name in their
> devlink_ops::info_get() callback. Now that the core provides this
> information, the callback became empty. For such drivers, just
> removing the callback would prevent the core from executing
> devlink_nl_info_fill() meaning that "devlink dev info" would not
> return anything.
> 
> Make the callback function optional by executing
> devlink_nl_info_fill() even if devlink_ops::info_get() is NULL.
> 
> N.B.: the drivers with devlink support which previously did not
> implement devlink_ops::info_get() will now also be able to report
> the driver name.
> 

Makes sense to me.

Thanks,
Jake