| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <CO1PR11MB50891004D6603019D2920DDED6129@CO1PR11MB5089.namprd11.prod.outlook.com>
Date: Tue, 29 Nov 2022 00:25:26 +0000
From: "Keller, Jacob E" <jacob.e.keller@...el.com>
To: Vincent Mailhol <mailhol.vincent@...adoo.fr>,
Jiri Pirko <jiri@...dia.com>,
"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
"Jakub Kicinski" <kuba@...nel.org>
CC: "David S . Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Paolo Abeni <pabeni@...hat.com>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"Boris Brezillon" <bbrezillon@...nel.org>,
Arnaud Ebalard <arno@...isbad.org>,
Srujana Challa <schalla@...vell.com>,
Kurt Kanzenbach <kurt@...utronix.de>,
Andrew Lunn <andrew@...n.ch>,
Florian Fainelli <f.fainelli@...il.com>,
Vladimir Oltean <olteanv@...il.com>,
Michael Chan <michael.chan@...adcom.com>,
Ioana Ciornei <ioana.ciornei@....com>,
"Dimitris Michailidis" <dmichail@...gible.com>,
Yisen Zhuang <yisen.zhuang@...wei.com>,
Salil Mehta <salil.mehta@...wei.com>,
"Brandeburg, Jesse" <jesse.brandeburg@...el.com>,
"Nguyen, Anthony L" <anthony.l.nguyen@...el.com>,
Sunil Goutham <sgoutham@...vell.com>,
"Linu Cherian" <lcherian@...vell.com>,
Geetha sowjanya <gakula@...vell.com>,
"Jerin Jacob" <jerinj@...vell.com>,
hariprasad <hkelam@...vell.com>,
"Subbaraya Sundeep" <sbhatta@...vell.com>,
Taras Chornyi <tchornyi@...vell.com>,
"Saeed Mahameed" <saeedm@...dia.com>,
Leon Romanovsky <leon@...nel.org>,
"Ido Schimmel" <idosch@...dia.com>,
Petr Machata <petrm@...dia.com>,
Simon Horman <simon.horman@...igine.com>,
Shannon Nelson <snelson@...sando.io>,
"drivers@...sando.io" <drivers@...sando.io>,
Ariel Elior <aelior@...vell.com>,
Manish Chopra <manishc@...vell.com>,
Jonathan Lemon <jonathan.lemon@...il.com>,
Vadim Fedorenko <vadfed@...com>,
Richard Cochran <richardcochran@...il.com>,
Vadim Pasternak <vadimp@...lanox.com>,
"Shalom Toledo" <shalomt@...lanox.com>,
"linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>,
"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
"linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
"oss-drivers@...igine.com" <oss-drivers@...igine.com>,
Jiri Pirko <jiri@...lanox.com>,
Herbert Xu <herbert@...dor.apana.org.au>,
Hao Chen <chenhao288@...ilicon.com>,
"Guangbin Huang" <huangguangbin2@...wei.com>,
Minghao Chi <chi.minghao@....com.cn>,
Shijith Thotton <sthotton@...vell.com>
Subject: RE: [PATCH net-next v5 0/4] net: devlink: return the driver name in
devlink_nl_info_fill
> -----Original Message-----
> From: Vincent Mailhol <vincent.mailhol@...il.com> On Behalf Of Vincent
> Mailhol
> Sent: Monday, November 28, 2022 4:06 PM
> To: Jiri Pirko <jiri@...dia.com>; netdev@...r.kernel.org; Jakub Kicinski
> <kuba@...nel.org>
> Cc: David S . Miller <davem@...emloft.net>; Eric Dumazet
> <edumazet@...gle.com>; Paolo Abeni <pabeni@...hat.com>; linux-
> kernel@...r.kernel.org; Boris Brezillon <bbrezillon@...nel.org>; Arnaud Ebalard
> <arno@...isbad.org>; Srujana Challa <schalla@...vell.com>; Kurt Kanzenbach
> <kurt@...utronix.de>; Andrew Lunn <andrew@...n.ch>; Florian Fainelli
> <f.fainelli@...il.com>; Vladimir Oltean <olteanv@...il.com>; Michael Chan
> <michael.chan@...adcom.com>; Ioana Ciornei <ioana.ciornei@....com>;
> Dimitris Michailidis <dmichail@...gible.com>; Yisen Zhuang
> <yisen.zhuang@...wei.com>; Salil Mehta <salil.mehta@...wei.com>;
> Brandeburg, Jesse <jesse.brandeburg@...el.com>; Nguyen, Anthony L
> <anthony.l.nguyen@...el.com>; Sunil Goutham <sgoutham@...vell.com>; Linu
> Cherian <lcherian@...vell.com>; Geetha sowjanya <gakula@...vell.com>;
> Jerin Jacob <jerinj@...vell.com>; hariprasad <hkelam@...vell.com>;
> Subbaraya Sundeep <sbhatta@...vell.com>; Taras Chornyi
> <tchornyi@...vell.com>; Saeed Mahameed <saeedm@...dia.com>; Leon
> Romanovsky <leon@...nel.org>; Ido Schimmel <idosch@...dia.com>; Petr
> Machata <petrm@...dia.com>; Simon Horman <simon.horman@...igine.com>;
> Shannon Nelson <snelson@...sando.io>; drivers@...sando.io; Ariel Elior
> <aelior@...vell.com>; Manish Chopra <manishc@...vell.com>; Jonathan
> Lemon <jonathan.lemon@...il.com>; Vadim Fedorenko <vadfed@...com>;
> Richard Cochran <richardcochran@...il.com>; Vadim Pasternak
> <vadimp@...lanox.com>; Shalom Toledo <shalomt@...lanox.com>; linux-
> crypto@...r.kernel.org; intel-wired-lan@...ts.osuosl.org; linux-
> rdma@...r.kernel.org; oss-drivers@...igine.com; Jiri Pirko
> <jiri@...lanox.com>; Herbert Xu <herbert@...dor.apana.org.au>; Hao Chen
> <chenhao288@...ilicon.com>; Guangbin Huang
> <huangguangbin2@...wei.com>; Minghao Chi <chi.minghao@....com.cn>;
> Shijith Thotton <sthotton@...vell.com>; Vincent Mailhol
> <mailhol.vincent@...adoo.fr>
> Subject: [PATCH net-next v5 0/4] net: devlink: return the driver name in
> devlink_nl_info_fill
>
> The driver name is available in device_driver::name. Right now,
> drivers still have to report this piece of information themselves in
> their devlink_ops::info_get callback function.
>
> The goal of this series is to have the devlink core to report this
> information instead of the drivers.
>
> The first patch fulfills the actual goal of this series: modify
> devlink core to report the driver name and clean-up all drivers. Both
> have to be done in an atomic change to avoid attribute duplication.
>
> The second patch removes the devlink_info_driver_name_put() function
> to prevent future drivers from reporting the driver name themselves.
>
> The third patch allows the core to call devlink_nl_info_fill() even if
> the devlink_ops::info_get() callback is NULL. This leads to the fourth
> and final patch which cleans up the drivers which have an empty
> info_get().
> ---
Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>
I'm fine with keeping it 4 patches as-is. Thanks!
> * Changelog *
>
> v4 -> v5
>
> * [PATCH 1/4] add Tested-by: Ido Schimmel tag.
>
> * split patch 3/3 in two patches.
>
> v3 -> v4
>
> * Ido pointed out that the mlxsw did not need to be fixed:
> https://lore.kernel.org/netdev/Y4ONgD4dAj8yU2%2F+@shredder/
> Remove the first two patches from the series.
>
> v2 -> v3
>
> * [PATCH 3/5] remove the call to devlink_info_driver_name_put() in
> mlxsw driver as well (this was missing in v2, making the build
> fail... sorry for the noise).
>
> * add additional people in CC as pointed by netdev patchwork CI:
> https://patchwork.kernel.org/project/netdevbpf/list/?series=699451
>
> * use the "Link:" prefix before URL to silence checkpatch's line
> length warning.
>
>
> RFC v1 -> v2
>
> * drop the RFC tag
>
> * big rework following the discussion on RFC:
> https://lore.kernel.org/netdev/20221122154934.13937-1-
> mailhol.vincent@...adoo.fr/
> Went from one patch to a series of five patches:
>
> * drop the idea to report the USB serial number following Greg's
> comment:
> https://lore.kernel.org/linux-usb/Y3+VfNdt%2FK7UtRcw@kroah.com/
>
> Vincent Mailhol (4):
> net: devlink: let the core report the driver name instead of the
> drivers
> net: devlink: remove devlink_info_driver_name_put()
> net: devlink: make the devlink_ops::info_get() callback optional
> net: devlink: clean-up empty devlink_ops::info_get()
>
> .../marvell/octeontx2/otx2_cpt_devlink.c | 4 ---
> drivers/net/dsa/hirschmann/hellcreek.c | 5 ---
> drivers/net/dsa/mv88e6xxx/devlink.c | 5 ---
> drivers/net/dsa/sja1105/sja1105_devlink.c | 12 ++-----
> .../net/ethernet/broadcom/bnxt/bnxt_devlink.c | 4 ---
> .../freescale/dpaa2/dpaa2-eth-devlink.c | 11 +-----
> .../ethernet/fungible/funeth/funeth_devlink.c | 7 ----
> .../hisilicon/hns3/hns3pf/hclge_devlink.c | 5 ---
> .../hisilicon/hns3/hns3vf/hclgevf_devlink.c | 5 ---
> drivers/net/ethernet/intel/ice/ice_devlink.c | 6 ----
> .../marvell/octeontx2/af/rvu_devlink.c | 7 ----
> .../marvell/octeontx2/nic/otx2_devlink.c | 15 --------
> .../marvell/prestera/prestera_devlink.c | 5 ---
> .../net/ethernet/mellanox/mlx5/core/devlink.c | 4 ---
> drivers/net/ethernet/mellanox/mlxsw/core.c | 5 ---
> .../net/ethernet/netronome/nfp/nfp_devlink.c | 4 ---
> .../ethernet/pensando/ionic/ionic_devlink.c | 4 ---
> drivers/net/ethernet/qlogic/qed/qed_devlink.c | 4 ---
> drivers/net/netdevsim/dev.c | 3 --
> drivers/ptp/ptp_ocp.c | 4 ---
> include/net/devlink.h | 2 --
> net/core/devlink.c | 35 ++++++++++++-------
> 22 files changed, 26 insertions(+), 130 deletions(-)
>
> --
> 2.25.1
Powered by blists - more mailing lists