linux-kernel - Re: [PATCH v2 1/6] hwmon: (gxp-fan-ctrl) Add GXP fan controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 29 Nov 2022 14:58:43 +0800
From:   kernel test robot <lkp@...el.com>
To:     nick.hawkins@....com, jdelvare@...e.com, linux@...ck-us.net,
        robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
        verdun@....com, corbet@....net, linux@...linux.org.uk,
        linux-hwmon@...r.kernel.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org, linux-doc@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org
Cc:     oe-kbuild-all@...ts.linux.dev
Subject: Re: [PATCH v2 1/6] hwmon: (gxp-fan-ctrl) Add GXP fan controller

Hi,

I love your patch! Perhaps something to improve:

[auto build test WARNING on groeck-staging/hwmon-next]
[also build test WARNING on robh/for-next linus/master v6.1-rc7 next-20221129]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/nick-hawkins-hpe-com/ARM-Add-GXP-Fan-and-SPI-controllers/20221129-070537
base:   https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git hwmon-next
patch link:    https://lore.kernel.org/r/20221128230219.39537-2-nick.hawkins%40hpe.com
patch subject: [PATCH v2 1/6] hwmon: (gxp-fan-ctrl) Add GXP fan controller
config: sparc-allyesconfig
compiler: sparc64-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/08b4f146002742edb3de971dfd0c1df7ab9cef21
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review nick-hawkins-hpe-com/ARM-Add-GXP-Fan-and-SPI-controllers/20221129-070537
        git checkout 08b4f146002742edb3de971dfd0c1df7ab9cef21
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=sparc SHELL=/bin/bash drivers/hwmon/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   drivers/hwmon/gxp-fan-ctrl.c: In function 'gxp_fan_ctrl_is_visible':
>> drivers/hwmon/gxp-fan-ctrl.c:158:17: warning: this statement may fall through [-Wimplicit-fallthrough=]
     158 |                 switch (attr) {
         |                 ^~~~~~
   drivers/hwmon/gxp-fan-ctrl.c:165:9: note: here
     165 |         case hwmon_pwm:
         |         ^~~~


vim +158 drivers/hwmon/gxp-fan-ctrl.c

   149	
   150	static umode_t gxp_fan_ctrl_is_visible(const void *_data,
   151					       enum hwmon_sensor_types type,
   152					       u32 attr, int channel)
   153	{
   154		umode_t mode = 0;
   155	
   156		switch (type) {
   157		case hwmon_fan:
 > 158			switch (attr) {
   159			case hwmon_fan_enable:
   160			case hwmon_fan_fault:
   161				mode = 0444;
   162			default:
   163				break;
   164			}
   165		case hwmon_pwm:
   166			switch (attr) {
   167			case hwmon_pwm_input:
   168				mode = 0644;
   169			default:
   170				break;
   171			}
   172		default:
   173			break;
   174		}
   175	
   176		return mode;
   177	}
   178	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (322261 bytes)