[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <e4676089-7ce2-e123-4e2a-a7d8835e9118@linaro.org>
Date: Tue, 29 Nov 2022 09:53:48 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Chukun Pan <amadeus@....edu.cn>,
"David S . Miller" <davem@...emloft.net>
Cc: Giuseppe Cavallaro <peppe.cavallaro@...com>,
Alexandre Torgue <alexandre.torgue@...s.st.com>,
Jose Abreu <joabreu@...opsys.com>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>,
David Wu <david.wu@...k-chips.com>,
Rob Herring <robh+dt@...nel.org>,
Heiko Stuebner <heiko@...ech.de>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
netdev@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 2/2] ethernet: stmicro: stmmac: Add SGMII/QSGMII support
for RK3568
On 29/11/2022 08:27, Chukun Pan wrote:
> From: David Wu <david.wu@...k-chips.com>
>
> The gmac of RK3568 supports RGMII/SGMII/QSGMII interface.
> This patch adds the remaining SGMII/QSGMII support.
Do not use "This commit/patch".
https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95
>
> Run-tested-on: Ariaboard Photonicat (GMAC0 SGMII)
>
> Signed-off-by: David Wu <david.wu@...k-chips.com>
> [rebase, rewrite commit message]
> Signed-off-by: Chukun Pan <amadeus@....edu.cn>
> ---
> .../net/ethernet/stmicro/stmmac/dwmac-rk.c | 210 +++++++++++++++++-
> 1 file changed, 207 insertions(+), 3 deletions(-)
>
>
> -static int phy_power_on(struct rk_priv_data *bsp_priv, bool enable)
> +static int rk_gmac_phy_power_on(struct rk_priv_data *bsp_priv, bool enable)
> {
> struct regulator *ldo = bsp_priv->regulator;
> int ret;
> @@ -1728,6 +1909,18 @@ static struct rk_priv_data *rk_gmac_setup(struct platform_device *pdev,
> "rockchip,grf");
> bsp_priv->php_grf = syscon_regmap_lookup_by_phandle(dev->of_node,
> "rockchip,php-grf");
> + bsp_priv->xpcs = syscon_regmap_lookup_by_phandle(dev->of_node,
> + "rockchip,xpcs");
> + if (!IS_ERR(bsp_priv->xpcs)) {
> + struct phy *comphy;
> +
> + comphy = devm_of_phy_get(&pdev->dev, dev->of_node, NULL);
So instead of having PHY driver, you added a syscon and implemented PHY
driver here. No. Make a proper PHY driver.
Best regards,
Krzysztof
Powered by blists - more mailing lists