[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <BYAPR11MB336772D78CBD1F38C8054636FC129@BYAPR11MB3367.namprd11.prod.outlook.com>
Date: Tue, 29 Nov 2022 14:41:02 +0000
From: "G, GurucharanX" <gurucharanx.g@...el.com>
To: Akihiko Odaki <akihiko.odaki@...nix.com>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"Yuri Benditovich" <yuri.benditovich@...nix.com>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>,
Yan Vugenfirer <yan@...nix.com>,
"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
Paolo Abeni <pabeni@...hat.com>,
"David S. Miller" <davem@...emloft.net>
Subject: RE: [Intel-wired-lan] [PATCH net v4] igb: Allocate MSI-X vector when
testing
> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of
> Akihiko Odaki
> Sent: Friday, November 25, 2022 7:01 PM
> Cc: netdev@...r.kernel.org; linux-kernel@...r.kernel.org; Yuri Benditovich
> <yuri.benditovich@...nix.com>; Eric Dumazet <edumazet@...gle.com>;
> Jakub Kicinski <kuba@...nel.org>; Yan Vugenfirer <yan@...nix.com>; intel-
> wired-lan@...ts.osuosl.org; Paolo Abeni <pabeni@...hat.com>; David S.
> Miller <davem@...emloft.net>
> Subject: [Intel-wired-lan] [PATCH net v4] igb: Allocate MSI-X vector when
> testing
>
> Without this change, the interrupt test fail with MSI-X environment:
>
> $ sudo ethtool -t enp0s2 offline
> [ 43.921783] igb 0000:00:02.0: offline testing starting
> [ 44.855824] igb 0000:00:02.0 enp0s2: igb: enp0s2 NIC Link is Down
> [ 44.961249] igb 0000:00:02.0 enp0s2: igb: enp0s2 NIC Link is Up 1000 Mbps
> Full Duplex, Flow Control: RX/TX
> [ 51.272202] igb 0000:00:02.0: testing shared interrupt
> [ 56.996975] igb 0000:00:02.0 enp0s2: igb: enp0s2 NIC Link is Up 1000 Mbps
> Full Duplex, Flow Control: RX/TX
> The test result is FAIL
> The test extra info:
> Register test (offline) 0
> Eeprom test (offline) 0
> Interrupt test (offline) 4
> Loopback test (offline) 0
> Link test (on/offline) 0
>
> Here, "4" means an expected interrupt was not delivered.
>
> To fix this, route IRQs correctly to the first MSI-X vector by setting
> IVAR_MISC. Also, set bit 0 of EIMS so that the vector will not be masked. The
> interrupt test now runs properly with this change:
>
> $ sudo ethtool -t enp0s2 offline
> [ 42.762985] igb 0000:00:02.0: offline testing starting
> [ 50.141967] igb 0000:00:02.0: testing shared interrupt
> [ 56.163957] igb 0000:00:02.0 enp0s2: igb: enp0s2 NIC Link is Up 1000 Mbps
> Full Duplex, Flow Control: RX/TX
> The test result is PASS
> The test extra info:
> Register test (offline) 0
> Eeprom test (offline) 0
> Interrupt test (offline) 0
> Loopback test (offline) 0
> Link test (on/offline) 0
>
> Fixes: 4eefa8f01314 ("igb: add single vector msi-x testing to interrupt test")
> Signed-off-by: Akihiko Odaki <akihiko.odaki@...nix.com>
> ---
> V3 -> V4: Added Fixes: tag
>
> drivers/net/ethernet/intel/igb/igb_ethtool.c | 2 ++
> 1 file changed, 2 insertions(+)
>
Tested-by: Gurucharan G <gurucharanx.g@...el.com> (A Contingent worker at Intel)
Powered by blists - more mailing lists