[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Y4YpELN4/0cesonb@dev-arch.thelio-3990X>
Date: Tue, 29 Nov 2022 08:45:20 -0700
From: Nathan Chancellor <nathan@...nel.org>
To: Srinivasa Rao Mandadapu <quic_srivasam@...cinc.com>
Cc: agross@...nel.org, andersson@...nel.org, lgirdwood@...il.com,
broonie@...nel.org, robh+dt@...nel.org, quic_plai@...cinc.com,
bgoswami@...cinc.com, perex@...ex.cz, tiwai@...e.com,
srinivas.kandagatla@...aro.org, quic_rohkumar@...cinc.com,
linux-arm-msm@...r.kernel.org, alsa-devel@...a-project.org,
linux-kernel@...r.kernel.org, swboyd@...omium.org,
judyhsiao@...omium.org, devicetree@...r.kernel.org
Subject: Re: [PATCH] ASoC: qcom: lpass-sc7180: Add maybe_unused tag for
system PM ops
On Tue, Nov 29, 2022 at 06:23:48PM +0530, Srinivasa Rao Mandadapu wrote:
> Add __maybe_unused tag for system PM ops suspend and resume.
> This is required to fix allmodconfig compilation issue.
> Fixes: c3bf7699747c ("ASoC: qcom: lpass-sc7280: Add system suspend/resume PM ops")
>
> Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@...cinc.com>
A better solution would be replacing SET_SYSTEM_SLEEP_PM_OPS() with
SYSTEM_SLEEP_PM_OPS(), which was added to avoid needing to add these
'__maybe_unused' attributes to these functions. See commit 1a3c7bb08826
("PM: core: Add new *_PM_OPS macros, deprecate old ones") for more info.
> ---
> sound/soc/qcom/lpass-sc7180.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/sound/soc/qcom/lpass-sc7180.c b/sound/soc/qcom/lpass-sc7180.c
> index b96b85a..41db661 100644
> --- a/sound/soc/qcom/lpass-sc7180.c
> +++ b/sound/soc/qcom/lpass-sc7180.c
> @@ -163,14 +163,14 @@ static int sc7180_lpass_exit(struct platform_device *pdev)
> return 0;
> }
>
> -static int sc7180_lpass_dev_resume(struct device *dev)
> +static int __maybe_unused sc7180_lpass_dev_resume(struct device *dev)
> {
> struct lpass_data *drvdata = dev_get_drvdata(dev);
>
> return clk_bulk_prepare_enable(drvdata->num_clks, drvdata->clks);
> }
>
> -static int sc7180_lpass_dev_suspend(struct device *dev)
> +static int __maybe_unused sc7180_lpass_dev_suspend(struct device *dev)
> {
> struct lpass_data *drvdata = dev_get_drvdata(dev);
>
> --
> 2.7.4
>
>
Powered by blists - more mailing lists