linux-kernel - Re: [PATCH] ASoC: qcom: lpass-sc7180: Add maybe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 29 Nov 2022 21:28:33 +0530
From:   Srinivasa Rao Mandadapu <quic_srivasam@...cinc.com>
To:     Nathan Chancellor <nathan@...nel.org>
CC:     <agross@...nel.org>, <andersson@...nel.org>, <lgirdwood@...il.com>,
        <broonie@...nel.org>, <robh+dt@...nel.org>,
        <quic_plai@...cinc.com>, <bgoswami@...cinc.com>, <perex@...ex.cz>,
        <tiwai@...e.com>, <srinivas.kandagatla@...aro.org>,
        <quic_rohkumar@...cinc.com>, <linux-arm-msm@...r.kernel.org>,
        <alsa-devel@...a-project.org>, <linux-kernel@...r.kernel.org>,
        <swboyd@...omium.org>, <judyhsiao@...omium.org>,
        <devicetree@...r.kernel.org>
Subject: Re: [PATCH] ASoC: qcom: lpass-sc7180: Add maybe_unused tag for system
 PM ops

Thanks for your tie Nathan!!!

On 11/29/2022 9:15 PM, Nathan Chancellor wrote:
> On Tue, Nov 29, 2022 at 06:23:48PM +0530, Srinivasa Rao Mandadapu wrote:
>> Add __maybe_unused tag for system PM ops suspend and resume.
>> This is required to fix allmodconfig compilation issue.
>> Fixes: c3bf7699747c ("ASoC: qcom: lpass-sc7280: Add system suspend/resume PM ops")
>>
>> Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@...cinc.com>
> A better solution would be replacing SET_SYSTEM_SLEEP_PM_OPS() with
> SYSTEM_SLEEP_PM_OPS(), which was added to avoid needing to add these
> '__maybe_unused' attributes to these functions. See commit 1a3c7bb08826
> ("PM: core: Add new *_PM_OPS macros, deprecate old ones") for more info.

Tried this option but as this patch required for Kernel 5.4 version code 
base,

SYSTEM_SLEEP_PM_OPS didn't work.

>> ---
>>   sound/soc/qcom/lpass-sc7180.c | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/sound/soc/qcom/lpass-sc7180.c b/sound/soc/qcom/lpass-sc7180.c
>> index b96b85a..41db661 100644
>> --- a/sound/soc/qcom/lpass-sc7180.c
>> +++ b/sound/soc/qcom/lpass-sc7180.c
>> @@ -163,14 +163,14 @@ static int sc7180_lpass_exit(struct platform_device *pdev)
>>   	return 0;
>>   }
>>   
>> -static int sc7180_lpass_dev_resume(struct device *dev)
>> +static int __maybe_unused sc7180_lpass_dev_resume(struct device *dev)
>>   {
>>   	struct lpass_data *drvdata = dev_get_drvdata(dev);
>>   
>>   	return clk_bulk_prepare_enable(drvdata->num_clks, drvdata->clks);
>>   }
>>   
>> -static int sc7180_lpass_dev_suspend(struct device *dev)
>> +static int __maybe_unused sc7180_lpass_dev_suspend(struct device *dev)
>>   {
>>   	struct lpass_data *drvdata = dev_get_drvdata(dev);
>>   
>> -- 
>> 2.7.4
>>
>>