lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <202211301541270908055@zte.com.cn>
Date:   Wed, 30 Nov 2022 15:41:27 +0800 (CST)
From:   <zhang.songyi@....com.cn>
To:     <saeedm@...dia.com>, <pabeni@...hat.com>
Cc:     <leon@...nel.org>, <davem@...emloft.net>, <edumazet@...gle.com>,
        <kuba@...nel.org>, <mbloch@...dia.com>, <maorg@...dia.com>,
        <elic@...dia.com>, <jerrliu@...dia.com>, <cmi@...dia.com>,
        <vladbu@...dia.com>, <netdev@...r.kernel.org>,
        <linux-rdma@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <zhang.songyi@....com.cn>
Subject: [PATCH net-next] net/mlx5: remove NULL check before dev_{put, hold}

From: zhang songyi <zhang.songyi@....com.cn>

The call netdev_{put, hold} of dev_{put, hold} will check NULL,
so there is no need to check before using dev_{put, hold}.

Fix the following coccicheck warning:
/drivers/net/ethernet/mellanox/mlx5/core/lag/lag.c:1450:2-10:
WARNING:
WARNING  NULL check before dev_{put, hold} functions is not needed.

Signed-off-by: zhang songyi <zhang.songyi@....com.cn>
---
 drivers/net/ethernet/mellanox/mlx5/core/lag/lag.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/mellanox/mlx5/core/lag/lag.c b/drivers/net/ethernet/mellanox/mlx5/core/lag/lag.c
index 32c3e0a649a7..6ab3a6b6dd8d 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/lag/lag.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/lag/lag.c
@@ -1448,8 +1448,7 @@ struct net_device *mlx5_lag_get_roce_netdev(struct mlx5_core_dev *dev)
        } else {
                ndev = ldev->pf[MLX5_LAG_P1].netdev;
        }
-       if (ndev)
-               dev_hold(ndev);
+       dev_hold(ndev);

 unlock:
        spin_unlock_irqrestore(&lag_lock, flags);
--
2.25.1

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ