linux-kernel - Re: [PATCH net-next] net/mlx5: remove NULL check before dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y4cbssiTgsGGNHlh@unreal>
Date:   Wed, 30 Nov 2022 11:00:34 +0200
From:   Leon Romanovsky <leon@...nel.org>
To:     zhang.songyi@....com.cn
Cc:     saeedm@...dia.com, pabeni@...hat.com, davem@...emloft.net,
        edumazet@...gle.com, kuba@...nel.org, mbloch@...dia.com,
        maorg@...dia.com, elic@...dia.com, jerrliu@...dia.com,
        cmi@...dia.com, vladbu@...dia.com, netdev@...r.kernel.org,
        linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] net/mlx5: remove NULL check before dev_{put,
 hold}

On Wed, Nov 30, 2022 at 03:41:27PM +0800, zhang.songyi@....com.cn wrote:
> From: zhang songyi <zhang.songyi@....com.cn>
> 
> The call netdev_{put, hold} of dev_{put, hold} will check NULL,
> so there is no need to check before using dev_{put, hold}.
> 
> Fix the following coccicheck warning:
> /drivers/net/ethernet/mellanox/mlx5/core/lag/lag.c:1450:2-10:
> WARNING:
> WARNING  NULL check before dev_{put, hold} functions is not needed.
> 
> Signed-off-by: zhang songyi <zhang.songyi@....com.cn>
> ---
>  drivers/net/ethernet/mellanox/mlx5/core/lag/lag.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

Please change all places in mlx5 in one patch.

You can find these with the following command
 git grep -B 1 -E "dev_put|dev_hold" drivers/net/ethernet/mellanox/mlx5/

Thanks

> 
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/lag/lag.c b/drivers/net/ethernet/mellanox/mlx5/core/lag/lag.c
> index 32c3e0a649a7..6ab3a6b6dd8d 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/lag/lag.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/lag/lag.c
> @@ -1448,8 +1448,7 @@ struct net_device *mlx5_lag_get_roce_netdev(struct mlx5_core_dev *dev)
>         } else {
>                 ndev = ldev->pf[MLX5_LAG_P1].netdev;
>         }
> -       if (ndev)
> -               dev_hold(ndev);
> +       dev_hold(ndev);
> 
>  unlock:
>         spin_unlock_irqrestore(&lag_lock, flags);
> --
> 2.25.1