linux-kernel - Re: [PATCH linux-next] printk: use strscpy() to instead of strlcpy()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <874jugx0wk.fsf@jogness.linutronix.de>
Date:   Wed, 30 Nov 2022 10:17:07 +0106
From:   John Ogness <john.ogness@...utronix.de>
To:     yang.yang29@....com.cn, pmladek@...e.com
Cc:     senozhatsky@...omium.org, rostedt@...dmis.org,
        linux-kernel@...r.kernel.org, xu.panda@....com.cn,
        yang.yang29@....com.cn
Subject: Re: [PATCH linux-next] printk: use strscpy() to instead of strlcpy()

On 2022-11-30, <yang.yang29@....com.cn> wrote:
> From: Xu Panda <xu.panda@....com.cn>
>
> The implementation of strscpy() is more robust and safer.
> That's now the recommended way to copy NUL terminated strings.
>
> Signed-off-by: Xu Panda <xu.panda@....com.cn>
> Signed-off-by: Yang Yang <yang.yang29@....com>

This looks fine, but I am wondering if we should also replace all
strncpy() usage as well. AFAICT they can all be replaced. It would also
avoid the manual termination in console_setup().

John Ogness