linux-kernel - Re: [PATCH] arm64: dts: qcom: sa8540p-ride: enable PCIe support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <861fa711-3355-b08e-f542-afd73953144f@linaro.org>
Date:   Wed, 30 Nov 2022 16:42:33 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Brian Masney <bmasney@...hat.com>, andersson@...nel.org
Cc:     agross@...nel.org, konrad.dybcio@...aro.org, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, linux-arm-msm@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        quic_shazhuss@...cinc.com, psodagud@...cinc.com,
        ahalaney@...hat.com, echanude@...hat.com
Subject: Re: [PATCH] arm64: dts: qcom: sa8540p-ride: enable PCIe support

On 30/11/2022 16:37, Brian Masney wrote:
> Add the vreg_l11a, pcie3a, pcie3a_phy, and tlmm nodes that are necessary
> in order to get PCIe working on the QDrive3.

Thank you for your patch. There is something to discuss/improve.


> +&pcie3a_phy {
> +	vdda-phy-supply = <&vreg_l11a>;
> +	vdda-pll-supply = <&vreg_l3a>;
> +
> +	status = "okay";
> +};
> +
>  &qup2 {
>  	status = "okay";
>  };
> @@ -158,6 +187,31 @@ &remoteproc_nsp1 {
>  	status = "okay";
>  };
>  
> +&tlmm {
> +	pcie3a_default: pcie3a-default {

Add suffix: -state

> +		perst {

-pins

Same in other places.

Best regards,
Krzysztof