linux-kernel - Re: [PATCH linux-next] dm: remove redundant sz variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y4eEC48JUauAZuio@redhat.com>
Date:   Wed, 30 Nov 2022 11:25:47 -0500
From:   Mike Snitzer <snitzer@...hat.com>
To:     zhang.songyi@....com.cn
Cc:     agk@...hat.com, snitzer@...nel.org, dm-devel@...hat.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH linux-next] dm: remove redundant sz variable

On Wed, Nov 30 2022 at  2:35P -0500,
zhang.songyi@....com.cn <zhang.songyi@....com.cn> wrote:

> From: zhang songyi <zhang.songyi@....com.cn>
> 
> Return value from hst_status() directly instead of taking
> this in another redundant variable.
> 
> Signed-off-by: zhang songyi <zhang.songyi@....com.cn>
> ---
>  drivers/md/dm-ps-historical-service-time.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/md/dm-ps-historical-service-time.c b/drivers/md/dm-ps-historical-service-time.c
> index 1d82c95d323d..6c8e83ad2662 100644
> --- a/drivers/md/dm-ps-historical-service-time.c
> +++ b/drivers/md/dm-ps-historical-service-time.c
> @@ -237,7 +237,6 @@ static void hst_destroy(struct path_selector *ps)
>  static int hst_status(struct path_selector *ps, struct dm_path *path,
>                      status_type_t type, char *result, unsigned int maxlen)
>  {
> -       unsigned int sz = 0;
>         struct path_info *pi;
> 
>         if (!path) {
> @@ -261,7 +260,7 @@ static int hst_status(struct path_selector *ps, struct dm_path *path,
>                 }
>         }
> 
> -       return sz;
> +       return 0;
>  }
> 
>  static int hst_add_path(struct path_selector *ps, struct dm_path *path,
> --
> 2.15.2
> 

NACK

This sz variable is needed! (see DMEMIT)