linux-kernel - Re: [PATCH 05/43] mm: Expand vma iterator interface.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 1 Dec 2022 00:35:52 +0800
From:   kernel test robot <lkp@...el.com>
To:     Liam Howlett <liam.howlett@...cle.com>,
        "maple-tree@...ts.infradead.org" <maple-tree@...ts.infradead.org>,
        "linux-mm@...ck.org" <linux-mm@...ck.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Andrew Morton <akpm@...ux-foundation.org>
Cc:     oe-kbuild-all@...ts.linux.dev,
        Liam Howlett <liam.howlett@...cle.com>
Subject: Re: [PATCH 05/43] mm: Expand vma iterator interface.

Hi Liam,

I love your patch! Yet something to improve:

[auto build test ERROR on acme/perf/core]
[also build test ERROR on linus/master v6.1-rc7 next-20221130]
[cannot apply to kees/for-next/execve tip/sched/core tip/perf/core]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Liam-Howlett/VMA-type-safety-through-VMA-iterator/20221130-104546
base:   https://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git perf/core
patch link:    https://lore.kernel.org/r/20221129164352.3374638-6-Liam.Howlett%40oracle.com
patch subject: [PATCH 05/43] mm: Expand vma iterator interface.
config: arc-defconfig
compiler: arc-elf-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/cca685c9cb2e968b4246a2f376b1213522f09fc0
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Liam-Howlett/VMA-type-safety-through-VMA-iterator/20221130-104546
        git checkout cca685c9cb2e968b4246a2f376b1213522f09fc0
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arc SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   mm/mmap.c: In function 'vma_iter_store':
>> mm/mmap.c:172:17: error: implicit declaration of function 'mt_dump'; did you mean 'xa_dump'? [-Werror=implicit-function-declaration]
     172 |                 mt_dump(vmi->mas.tree);
         |                 ^~~~~~~
         |                 xa_dump
   cc1: some warnings being treated as errors


vim +172 mm/mmap.c

   163	
   164	/* Store a VMA with preallocated memory */
   165	static inline void vma_iter_store(struct vma_iterator *vmi,
   166					  struct vm_area_struct *vma)
   167	{
   168		if (WARN_ON(vmi->mas.node != MAS_START && vmi->mas.index > vma->vm_start)) {
   169			printk("%lu > %lu\n", vmi->mas.index, vma->vm_start);
   170			printk("store of vma %lu-%lu", vma->vm_start, vma->vm_end);
   171			printk("into slot    %lu-%lu", vmi->mas.index, vmi->mas.last);
 > 172			mt_dump(vmi->mas.tree);
   173		}
   174		if (WARN_ON(vmi->mas.node != MAS_START && vmi->mas.last <  vma->vm_start)) {
   175			printk("%lu < %lu\n", vmi->mas.last, vma->vm_start);
   176			printk("store of vma %lu-%lu", vma->vm_start, vma->vm_end);
   177			printk("into slot    %lu-%lu", vmi->mas.index, vmi->mas.last);
   178			mt_dump(vmi->mas.tree);
   179		}
   180	
   181		if (vmi->mas.node != MAS_START &&
   182		    ((vmi->mas.index > vma->vm_start) || (vmi->mas.last < vma->vm_start)))
   183			vma_iter_invalidate(vmi);
   184	
   185		vmi->mas.index = vma->vm_start;
   186		vmi->mas.last = vma->vm_end - 1;
   187		mas_store_prealloc(&vmi->mas, vma);
   188	}
   189	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (39706 bytes)