linux-kernel - Re: [PATCH 26/43] mmap: Convert __vma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 2 Dec 2022 03:53:09 +0800
From:   kernel test robot <lkp@...el.com>
To:     Liam Howlett <liam.howlett@...cle.com>,
        "maple-tree@...ts.infradead.org" <maple-tree@...ts.infradead.org>,
        "linux-mm@...ck.org" <linux-mm@...ck.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Andrew Morton <akpm@...ux-foundation.org>
Cc:     oe-kbuild-all@...ts.linux.dev,
        Liam Howlett <liam.howlett@...cle.com>
Subject: Re: [PATCH 26/43] mmap: Convert __vma_adjust() to use vma iterator

Hi Liam,

I love your patch! Yet something to improve:

[auto build test ERROR on acme/perf/core]
[cannot apply to kees/for-next/execve tip/sched/core tip/perf/core linus/master v6.1-rc7 next-20221201]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Liam-Howlett/VMA-type-safety-through-VMA-iterator/20221130-104546
base:   https://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git perf/core
patch link:    https://lore.kernel.org/r/20221129164352.3374638-27-Liam.Howlett%40oracle.com
patch subject: [PATCH 26/43] mmap: Convert __vma_adjust() to use vma iterator
config: mips-allyesconfig
compiler: mips-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/793c736cc42f0770e67b041afeeba351ab482bc7
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Liam-Howlett/VMA-type-safety-through-VMA-iterator/20221130-104546
        git checkout 793c736cc42f0770e67b041afeeba351ab482bc7
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=mips SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   In file included from mm/damon/vaddr.c:715:
   mm/damon/vaddr-test.h: In function '__link_vmas':
>> mm/damon/vaddr-test.h:28:17: error: implicit declaration of function 'vma_mas_store'; did you mean 'mas_store'? [-Werror=implicit-function-declaration]
      28 |                 vma_mas_store(&vmas[i], &mas);
         |                 ^~~~~~~~~~~~~
         |                 mas_store
   cc1: some warnings being treated as errors


vim +28 mm/damon/vaddr-test.h

17ccae8bb5c928 SeongJae Park   2021-09-07  16  
d0cf3dd47f0d5d Liam R. Howlett 2022-09-06  17  static void __link_vmas(struct maple_tree *mt, struct vm_area_struct *vmas,
d0cf3dd47f0d5d Liam R. Howlett 2022-09-06  18  			ssize_t nr_vmas)
17ccae8bb5c928 SeongJae Park   2021-09-07  19  {
d0cf3dd47f0d5d Liam R. Howlett 2022-09-06  20  	int i;
d0cf3dd47f0d5d Liam R. Howlett 2022-09-06  21  	MA_STATE(mas, mt, 0, 0);
17ccae8bb5c928 SeongJae Park   2021-09-07  22  
17ccae8bb5c928 SeongJae Park   2021-09-07  23  	if (!nr_vmas)
17ccae8bb5c928 SeongJae Park   2021-09-07  24  		return;
17ccae8bb5c928 SeongJae Park   2021-09-07  25  
d0cf3dd47f0d5d Liam R. Howlett 2022-09-06  26  	mas_lock(&mas);
d0cf3dd47f0d5d Liam R. Howlett 2022-09-06  27  	for (i = 0; i < nr_vmas; i++)
d0cf3dd47f0d5d Liam R. Howlett 2022-09-06 @28  		vma_mas_store(&vmas[i], &mas);
d0cf3dd47f0d5d Liam R. Howlett 2022-09-06  29  	mas_unlock(&mas);
17ccae8bb5c928 SeongJae Park   2021-09-07  30  }
17ccae8bb5c928 SeongJae Park   2021-09-07  31  

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (327595 bytes)