linux-kernel - Re: [PATCH v4] modules: add modalias file to sysfs for modules.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y4hEUP31sbGl5vw8@kroah.com>
Date:   Thu, 1 Dec 2022 07:06:08 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Allen Webb <allenwebb@...gle.com>
Cc:     Christophe Leroy <christophe.leroy@...roup.eu>,
        Luis Chamberlain <mcgrof@...nel.org>,
        "linux-modules@...r.kernel.org" <linux-modules@...r.kernel.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4] modules: add modalias file to sysfs for modules.

On Wed, Nov 30, 2022 at 04:14:47PM -0600, Allen Webb wrote:
> USB devices support the authorized attribute which can be used by
> user-space to implement trust-based systems for enabling USB devices. It
> would be helpful when building these systems to be able to know in
> advance which kernel drivers (or modules) are reachable from a
> particular USB device.
> 
> This information is readily available for external modules in
> modules.alias. However, builtin kernel modules are not covered. This
> patch adds a sys-fs attribute to both builtin and loaded modules
> exposing the matching rules in the modalias format for integration
> with tools like USBGuard.
> 
> Signed-off-by: Allen Webb <allenwebb@...gle.com>
> ---
>  drivers/base/Makefile          |   2 +-
>  drivers/base/base.h            |   8 +
>  drivers/base/bus.c             |  42 ++++++
>  drivers/base/mod_devicetable.c | 257 +++++++++++++++++++++++++++++++++
>  drivers/usb/core/driver.c      |   2 +
>  include/linux/device/bus.h     |   8 +
>  include/linux/module.h         |   1 +
>  kernel/module/internal.h       |   2 +
>  kernel/module/sysfs.c          |  88 +++++++++++
>  kernel/params.c                |   7 +
>  10 files changed, 416 insertions(+), 1 deletion(-)
>  create mode 100644 drivers/base/mod_devicetable.c
> 
> Fixed another kernel config incompability identified by:
> | Reported-by: kernel test robot <lkp@...el.com>
> 
> Fixed a couple CHECK messages from checkpatch.pl.
> 
> There are still some CHECK messages that are by design in a macro that
> depends on modifying a parameter and string literal concatenation.
> 
> There is also a maintainer file update warning for a new file, but that
> file is already covered by an existing maintainers entry.
> 

Again, please read the kernel documentation for how to list changes that
have happened since the 1st version you submitted, it's impossible to
know what has changed in each version here, right?  Also how has this
changed based on the reviews of the first release where people pointed
you at other alternatives?  How did they not work out?

You might need to start including a 0/1 email with all of this
information as it needs an introduction in places, right?

thanks,

greg k-h