[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAGXv+5Hj-H6Q3N+j2tEntd9M=9p0o7TxWYn_4aawhqFUbX7+PQ@mail.gmail.com>
Date: Thu, 1 Dec 2022 19:44:55 +0800
From: Chen-Yu Tsai <wenst@...omium.org>
To: "Nancy.Lin" <nancy.lin@...iatek.com>
Cc: Rob Herring <robh+dt@...nel.org>,
Matthias Brugger <matthias.bgg@...il.com>,
Chun-Kuang Hu <chunkuang.hu@...nel.org>,
Philipp Zabel <p.zabel@...gutronix.de>, wim@...ux-watchdog.org,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@...labora.com>, linux@...ck-us.net,
nfraprado@...labora.com, devicetree@...r.kernel.org,
Project_Global_Chrome_Upstream_Group@...iatek.com,
Yongqiang Niu <yongqiang.niu@...iatek.com>,
David Airlie <airlied@...ux.ie>,
"jason-jh . lin" <jason-jh.lin@...iatek.com>,
singo.chang@...iatek.com, llvm@...ts.linux.dev,
Nick Desaulniers <ndesaulniers@...gle.com>,
linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org,
Nathan Chancellor <nathan@...nel.org>,
linux-mediatek@...ts.infradead.org,
linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v28 05/11] soc: mediatek: refine code to use
mtk_mmsys_update_bits API
On Mon, Nov 7, 2022 at 3:23 PM Nancy.Lin <nancy.lin@...iatek.com> wrote:
>
> Simplify code for update mmsys reg.
>
> Signed-off-by: Nancy.Lin <nancy.lin@...iatek.com>
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
> Reviewed-by: CK Hu <ck.hu@...iatek.com>
> Tested-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
> Tested-by: Bo-Chen Chen <rex-bc.chen@...iatek.com>
> Reviewed-by: NĂcolas F. R. A. Prado <nfraprado@...labora.com>
> ---
> drivers/soc/mediatek/mtk-mmsys.c | 45 ++++++++++++--------------------
> 1 file changed, 16 insertions(+), 29 deletions(-)
>
> diff --git a/drivers/soc/mediatek/mtk-mmsys.c b/drivers/soc/mediatek/mtk-mmsys.c
> index 9a327eb5d9d7..73c8bd27e6ae 100644
> --- a/drivers/soc/mediatek/mtk-mmsys.c
> +++ b/drivers/soc/mediatek/mtk-mmsys.c
[...]
> @@ -124,27 +129,14 @@ void mtk_mmsys_ddp_disconnect(struct device *dev,
> {
> struct mtk_mmsys *mmsys = dev_get_drvdata(dev);
> const struct mtk_mmsys_routes *routes = mmsys->data->routes;
> - u32 reg;
> int i;
>
> for (i = 0; i < mmsys->data->num_routes; i++)
> - if (cur == routes[i].from_comp && next == routes[i].to_comp) {
> - reg = readl_relaxed(mmsys->regs + routes[i].addr);
> - reg &= ~routes[i].mask;
> - writel_relaxed(reg, mmsys->regs + routes[i].addr);
> - }
> + if (cur == routes[i].from_comp && next == routes[i].to_comp)
> + mtk_mmsys_update_bits(mmsys, routes[i].addr, routes[i].mask, 0);
> }
> EXPORT_SYMBOL_GPL(mtk_mmsys_ddp_disconnect);
>
> -static void mtk_mmsys_update_bits(struct mtk_mmsys *mmsys, u32 offset, u32 mask, u32 val)
> -{
> - u32 tmp;
> -
> - tmp = readl_relaxed(mmsys->regs + offset);
> - tmp = (tmp & ~mask) | val;
> - writel_relaxed(tmp, mmsys->regs + offset);
> -}
> -
> void mtk_mmsys_ddp_dpi_fmt_config(struct device *dev, u32 val)
> {
> if (val)
This hunk now doesn't apply due to
soc: mediatek: Add all settings to mtk_mmsys_ddp_dpi_fmt_config func
touching mtk_mmsys_ddp_dpi_fmt_config() as well. It's trivial to resolve
though.
ChenYu
Powered by blists - more mailing lists