[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <2c88e8f6327475539a1c6a8d9d8679c08efc2a85.camel@mediatek.com>
Date: Tue, 27 Dec 2022 07:54:15 +0000
From: Nancy Lin (林欣螢) <Nancy.Lin@...iatek.com>
To: "wenst@...omium.org" <wenst@...omium.org>
CC: "llvm@...ts.linux.dev" <llvm@...ts.linux.dev>,
Yongqiang Niu (牛永强)
<yongqiang.niu@...iatek.com>,
"robh+dt@...nel.org" <robh+dt@...nel.org>,
Singo Chang (張興國)
<Singo.Chang@...iatek.com>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"nathan@...nel.org" <nathan@...nel.org>,
"chunkuang.hu@...nel.org" <chunkuang.hu@...nel.org>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
"linux@...ck-us.net" <linux@...ck-us.net>,
"linux-mediatek@...ts.infradead.org"
<linux-mediatek@...ts.infradead.org>,
Jason-JH Lin (林睿祥)
<Jason-JH.Lin@...iatek.com>,
"p.zabel@...gutronix.de" <p.zabel@...gutronix.de>,
Project_Global_Chrome_Upstream_Group
<Project_Global_Chrome_Upstream_Group@...iatek.com>,
"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>,
"wim@...ux-watchdog.org" <wim@...ux-watchdog.org>,
"matthias.bgg@...il.com" <matthias.bgg@...il.com>,
"airlied@...ux.ie" <airlied@...ux.ie>,
"angelogioacchino.delregno@...labora.com"
<angelogioacchino.delregno@...labora.com>,
"nfraprado@...labora.com" <nfraprado@...labora.com>,
"ndesaulniers@...gle.com" <ndesaulniers@...gle.com>
Subject: Re: [PATCH v28 05/11] soc: mediatek: refine code to use
mtk_mmsys_update_bits API
Dear Chen-Yu,
Sorry for late response and thanks for the review.
On Thu, 2022-12-01 at 19:44 +0800, Chen-Yu Tsai wrote:
> On Mon, Nov 7, 2022 at 3:23 PM Nancy.Lin <nancy.lin@...iatek.com>
> wrote:
> >
> > Simplify code for update mmsys reg.
> >
> > Signed-off-by: Nancy.Lin <nancy.lin@...iatek.com>
> > Reviewed-by: AngeloGioacchino Del Regno <
> > angelogioacchino.delregno@...labora.com>
> > Reviewed-by: CK Hu <ck.hu@...iatek.com>
> > Tested-by: AngeloGioacchino Del Regno <
> > angelogioacchino.delregno@...labora.com>
> > Tested-by: Bo-Chen Chen <rex-bc.chen@...iatek.com>
> > Reviewed-by: Nícolas F. R. A. Prado <nfraprado@...labora.com>
> > ---
> > drivers/soc/mediatek/mtk-mmsys.c | 45 ++++++++++++--------------
> > ------
> > 1 file changed, 16 insertions(+), 29 deletions(-)
> >
> > diff --git a/drivers/soc/mediatek/mtk-mmsys.c
> > b/drivers/soc/mediatek/mtk-mmsys.c
> > index 9a327eb5d9d7..73c8bd27e6ae 100644
> > --- a/drivers/soc/mediatek/mtk-mmsys.c
> > +++ b/drivers/soc/mediatek/mtk-mmsys.c
>
> [...]
>
> > @@ -124,27 +129,14 @@ void mtk_mmsys_ddp_disconnect(struct device
> > *dev,
> > {
> > struct mtk_mmsys *mmsys = dev_get_drvdata(dev);
> > const struct mtk_mmsys_routes *routes = mmsys->data-
> > >routes;
> > - u32 reg;
> > int i;
> >
> > for (i = 0; i < mmsys->data->num_routes; i++)
> > - if (cur == routes[i].from_comp && next ==
> > routes[i].to_comp) {
> > - reg = readl_relaxed(mmsys->regs +
> > routes[i].addr);
> > - reg &= ~routes[i].mask;
> > - writel_relaxed(reg, mmsys->regs +
> > routes[i].addr);
> > - }
> > + if (cur == routes[i].from_comp && next ==
> > routes[i].to_comp)
> > + mtk_mmsys_update_bits(mmsys,
> > routes[i].addr, routes[i].mask, 0);
> > }
> > EXPORT_SYMBOL_GPL(mtk_mmsys_ddp_disconnect);
> >
> > -static void mtk_mmsys_update_bits(struct mtk_mmsys *mmsys, u32
> > offset, u32 mask, u32 val)
> > -{
> > - u32 tmp;
> > -
> > - tmp = readl_relaxed(mmsys->regs + offset);
> > - tmp = (tmp & ~mask) | val;
> > - writel_relaxed(tmp, mmsys->regs + offset);
> > -}
> > -
> > void mtk_mmsys_ddp_dpi_fmt_config(struct device *dev, u32 val)
> > {
> > if (val)
>
> This hunk now doesn't apply due to
>
> soc: mediatek: Add all settings to mtk_mmsys_ddp_dpi_fmt_config
> func
>
> touching mtk_mmsys_ddp_dpi_fmt_config() as well. It's trivial to
> resolve
> though.
>
> ChenYu
I will update next revision base on next-20221226 which include the
patch you mentioned.
Regards,
Nancy
Powered by blists - more mailing lists