linux-kernel - Re: [PATCH linux-next] pxa: Remove dev_err() after platform_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <f5b0c1a5-58ea-4ac4-bea0-aa887d42d04a@app.fastmail.com>
Date:   Thu, 01 Dec 2022 16:31:55 +0100
From:   "Arnd Bergmann" <arnd@...db.de>
To:     zhang.songyi@....com.cn
Cc:     "Robert Jarzmik" <robert.jarzmik@...e.fr>,
        "Lubomir Rintel" <lkundrak@...sk>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH linux-next] pxa: Remove dev_err() after platform_get_irq()

On Wed, Nov 30, 2022, at 08:56, zhang.songyi@....com.cn wrote:
> From: zhang songyi <zhang.songyi@....com.cn>
>
> There is no need to call the dev_err() function directly to print a
> custom message when handling an error from either the platform_get_irq()
> or platform_get_irq_byname() functions as both are going to display an
> appropriate error message in case of a failure.
>
> /drivers/soc/pxa/ssp.c:150:2-9: line 150 is redundant because
> platform_get_irq() already prints an error
>
> Signed-off-by: zhang songyi <zhang.songyi@....com.cn>
> ---
>  drivers/soc/pxa/ssp.c | 1 -
>  1 file changed, 1 deletion(-)

I tried to apply the patch, but it appears to be whitespace damaged
and does not apply, probably something wrong with your email client.

Can you make sure you are following the steps in 
Documentation/translations/zh_CN/process/email-clients.rst and
resend the patch, with Lubomir's Reviewed-by added in?

Usually the process it for platform maintainers to pick up patches,
but this time please send it directly to soc@...nel.org (since
there is already maintainer ack) and I'll pick it up from there.

Thanks,

       Arnd