linux-kernel - Re: [PATCH] Improved usability of the Makefile in libbpf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 2 Dec 2022 10:13:23 +0800
From:   Xin Liu <liuxin350@...wei.com>
To:     <andrii.nakryiko@...il.com>
CC:     <andrii@...nel.org>, <ast@...nel.org>, <bpf@...r.kernel.org>,
        <daniel@...earbox.net>, <haoluo@...gle.com>,
        <john.fastabend@...il.com>, <jolsa@...nel.org>,
        <kongweibin2@...wei.com>, <kpsingh@...nel.org>,
        <linux-kernel@...r.kernel.org>, <liuxin350@...wei.com>,
        <martin.lau@...ux.dev>, <sdf@...gle.com>, <song@...nel.org>,
        <wuchangye@...wei.com>, <xiesongyang@...wei.com>,
        <yanan@...wei.com>, <yhs@...com>, <zhangmingyi5@...wei.com>
Subject: Re: [PATCH] Improved usability of the Makefile in libbpf

On Wed, 30 Nov 2022 at 00:42:09 AM Andrii Nakryiko <andrii.nakryiko@...il.com> wrote:
> On Mon, Nov 28, 2022 at 11:42 PM Xin Liu <liuxin350@...wei.com> wrote:
> >
> > Current libbpf Makefile does not contain the help command, which
> > is inconvenient to use. A help command is provided to list the
> > commands supported by libbpf make and the functions of the commands.
> ...
> > +       @echo '  make prefix=/path      [install targets] use prefix for installing'
> > +       @echo '                                           into a user defined prefix path'
> 
> 
> I'm a bit hesitant about adding all this. Most of those targets are
> not intended to be used directly, only "all", "clean", and "install"
> are supposed to be used by end-users (maybe also "install_headers").
> And those seems to be pretty typical and straightforward targets.
> 
> I actually didn't even know about `make help`, but I checked perf's
> `make help` and it's way more succinct, let's try modeling it here?
> 
> Also, please use [PATCH bpf-next] (with v2 in between them) for next
> submission to point that this is meant for bpf-next tree.

Thanks to andrii's reply, I'll try to simplify the help command.

The original purpose of adding this is that when I use libbpf, libbpf installs
the file in /usr/local by default, and I didn't read the makefile carefully
before, so I need to open the makefile to read the code. Determine which
parameter is used to define the path that I want to customize. The makefile
of the kernel provides a make help instruction, which is much more convenient
to use.