linux-kernel - Re: [PATCH v2] infiniband: disable IB HW for UML

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 4 Dec 2022 15:21:53 +0200
From:   Leon Romanovsky <leon@...nel.org>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     linux-kernel@...r.kernel.org, Jason Gunthorpe <jgg@...dia.com>,
        Dennis Dalessandro <dennis.dalessandro@...nelisnetworks.com>,
        Christoph Hellwig <hch@...radead.org>,
        linux-rdma@...r.kernel.org, Jeff Dike <jdike@...toit.com>,
        Richard Weinberger <richard@....at>,
        Anton Ivanov <anton.ivanov@...bridgegreys.com>,
        Johannes Berg <johannes@...solutions.net>,
        linux-um@...ts.infradead.org
Subject: Re: [PATCH v2] infiniband: disable IB HW for UML

On Fri, Dec 02, 2022 at 01:19:40PM -0800, Randy Dunlap wrote:
> Disable all of drivers/infiniband/hw/ for UML builds until someone
> needs it and provides patches to support it.
> 
> This prevents build errors in hw/qib/qib_wc_x86_64.c.
> 
> Fixes: 68f5d3f3b654 ("um: add PCI over virtio emulation driver")
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Suggested-by: Leon Romanovsky <leon@...nel.org>
> Cc: Jason Gunthorpe <jgg@...dia.com>
> Cc: Dennis Dalessandro <dennis.dalessandro@...nelisnetworks.com>
> Cc: Christoph Hellwig <hch@...radead.org>
> Cc: linux-rdma@...r.kernel.org
> Cc: Jeff Dike <jdike@...toit.com>
> Cc: Richard Weinberger <richard@....at>
> Cc: Anton Ivanov <anton.ivanov@...bridgegreys.com>
> Cc: Johannes Berg <johannes@...solutions.net>
> Cc: linux-um@...ts.infradead.org
> ---
> v2: just disable infiniband/hw/, not all of infiniband.
> 
>  drivers/infiniband/Kconfig |    2 ++
>  1 file changed, 2 insertions(+)

I added rdmavt to the mix and applied.
https://lore.kernel.org/linux-rdma/20221130200958.25305-1-rdunlap@infradead.org/

diff --git a/drivers/infiniband/Kconfig b/drivers/infiniband/Kconfig
index 6ee97c898231..a5827d11e934 100644
--- a/drivers/infiniband/Kconfig
+++ b/drivers/infiniband/Kconfig
@@ -95,8 +95,8 @@ source "drivers/infiniband/hw/qedr/Kconfig"
 source "drivers/infiniband/hw/qib/Kconfig"
 source "drivers/infiniband/hw/usnic/Kconfig"
 source "drivers/infiniband/hw/vmw_pvrdma/Kconfig"
-endif # !UML
 source "drivers/infiniband/sw/rdmavt/Kconfig"
+endif # !UML
 source "drivers/infiniband/sw/rxe/Kconfig"
 source "drivers/infiniband/sw/siw/Kconfig"
 endif
(END)




> 
> diff -- a/drivers/infiniband/Kconfig b/drivers/infiniband/Kconfig
> --- a/drivers/infiniband/Kconfig
> +++ b/drivers/infiniband/Kconfig
> @@ -78,6 +78,7 @@ config INFINIBAND_VIRT_DMA
>  	def_bool !HIGHMEM
>  
>  if INFINIBAND_USER_ACCESS || !INFINIBAND_USER_ACCESS
> +if !UML
>  source "drivers/infiniband/hw/bnxt_re/Kconfig"
>  source "drivers/infiniband/hw/cxgb4/Kconfig"
>  source "drivers/infiniband/hw/efa/Kconfig"
> @@ -94,6 +95,7 @@ source "drivers/infiniband/hw/qedr/Kconf
>  source "drivers/infiniband/hw/qib/Kconfig"
>  source "drivers/infiniband/hw/usnic/Kconfig"
>  source "drivers/infiniband/hw/vmw_pvrdma/Kconfig"
> +endif # !UML
>  source "drivers/infiniband/sw/rdmavt/Kconfig"
>  source "drivers/infiniband/sw/rxe/Kconfig"
>  source "drivers/infiniband/sw/siw/Kconfig"