linux-kernel - Re: [PATCH linux-next] m68k: use strscpy() to instead of strncpy()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <62ee3765-b4fc-db79-5281-7295e43f4314@linux-m68k.org>
Date:   Mon, 5 Dec 2022 10:02:11 +1000
From:   Greg Ungerer <gerg@...ux-m68k.org>
To:     yang.yang29@....com.cn, geert@...ux-m68k.org
Cc:     linux-m68k@...ts.linux-m68k.org, linux-kernel@...r.kernel.org,
        xu.panda@....com.cn
Subject: Re: [PATCH linux-next] m68k: use strscpy() to instead of strncpy()

Hi Xu,

On 3/12/22 16:10, yang.yang29@....com.cn wrote:
> From: Xu Panda <xu.panda@....com.cn>
> 
> The implementation of strscpy() is more robust and safer.
> 
> Signed-off-by: Xu Panda <xu.panda@....com.cn>
> Signed-off-by: Yang Yang <yang.yang29@....com>

Thanks. Seeing as this is non-MMU related I'll take this through
the m68knommu git tree. Applied to the for-next branch.

Regards
Greg



> ---
>   arch/m68k/kernel/setup_no.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/arch/m68k/kernel/setup_no.c b/arch/m68k/kernel/setup_no.c
> index cb6def585851..37fb663559b4 100644
> --- a/arch/m68k/kernel/setup_no.c
> +++ b/arch/m68k/kernel/setup_no.c
> @@ -90,8 +90,7 @@ void __init setup_arch(char **cmdline_p)
>   	config_BSP(&command_line[0], sizeof(command_line));
> 
>   #if defined(CONFIG_BOOTPARAM)
> -	strncpy(&command_line[0], CONFIG_BOOTPARAM_STRING, sizeof(command_line));
> -	command_line[sizeof(command_line) - 1] = 0;
> +	strscpy(&command_line[0], CONFIG_BOOTPARAM_STRING, sizeof(command_line));
>   #endif /* CONFIG_BOOTPARAM */
> 
>   	process_uboot_commandline(&command_line[0], sizeof(command_line));