linux-kernel - Re: [PATCH v11 1/4] random: add vgetrandom

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y446mGVCvJX+5mGd@zx2c4.com>
Date:   Mon, 5 Dec 2022 19:38:16 +0100
From:   "Jason A. Donenfeld" <Jason@...c4.com>
To:     Florian Weimer <fweimer@...hat.com>
Cc:     linux-kernel@...r.kernel.org, patches@...ts.linux.dev,
        tglx@...utronix.de, linux-crypto@...r.kernel.org,
        linux-api@...r.kernel.org, x86@...nel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Adhemerval Zanella Netto <adhemerval.zanella@...aro.org>,
        Carlos O'Donell <carlos@...hat.com>,
        Arnd Bergmann <arnd@...db.de>,
        Christian Brauner <brauner@...nel.org>
Subject: Re: [PATCH v11 1/4] random: add vgetrandom_alloc() syscall

On Mon, Dec 05, 2022 at 07:34:39PM +0100, Florian Weimer wrote:
> > + *   - Passing the first state to munmap(2), as described above.
> > + * All other uses are undefined behavior, which is subject to change or removal
> 
> Suggest: “Passing the first state *and total length* to munmap(2)”

Will do.

> Rest of the documentation looks good to me.  It addresses my concerns
> about future evolution of this interface.

Great! So hopefully the api is more or less settled now, and we can turn
attention to the glibc part.

Jason