linux-kernel - Re: [PATCH v11 3/4] random: introduce generic vDSO getrandom() implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y45Ar3mwRBSr+X7F@zx2c4.com>
Date:   Mon, 5 Dec 2022 20:04:15 +0100
From:   "Jason A. Donenfeld" <Jason@...c4.com>
To:     Florian Weimer <fweimer@...hat.com>
Cc:     linux-kernel@...r.kernel.org, patches@...ts.linux.dev,
        tglx@...utronix.de, linux-crypto@...r.kernel.org,
        linux-api@...r.kernel.org, x86@...nel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Adhemerval Zanella Netto <adhemerval.zanella@...aro.org>,
        Carlos O'Donell <carlos@...hat.com>,
        Arnd Bergmann <arnd@...db.de>,
        Christian Brauner <brauner@...nel.org>
Subject: Re: [PATCH v11 3/4] random: introduce generic vDSO getrandom()
 implementation

Hi Florian,

On Mon, Dec 05, 2022 at 07:56:47PM +0100, Florian Weimer wrote:
> * Jason A. Donenfeld:
> 
> > +retry_generation:
> > +	/*
> > +	 * @rng_info->generation must always be read here, as it serializes @state->key with the
> > +	 * kernel's RNG reseeding schedule.
> > +	 */
> > +	current_generation = READ_ONCE(rng_info->generation);
> 
> > +		if (unlikely(READ_ONCE(state->generation) != READ_ONCE(rng_info-
> 
> I'm pretty sure you need some sort of barrier here.  We have a similar
> TM-lite construct in glibc ld.so for locating link maps by address, and
> there the compiler performed reordering.
> 
>   _dl_find_object miscompilation on powerpc64le
>   <https://sourceware.org/bugzilla/show_bug.cgi?id=28745>
> 
> I'm not familiar with READ_ONCE, but Documentation/atomic_t.txt suggests
> it's a “regular LOAD”, and include/asm-generic/rwonce.h concurs.

Do you mean compiler barriers or SMP barriers?

> Likewise, the signal safety mechanism needs compiler barriers (signal
> fences).

READ_ONCE() should prevent the compiler from reordering the read.
 
> I'm also not sure how READ_ONCE realizes atomic 64-bit reads on 32-bit
> platforms.  i386 can do them in user space via the FPU worst-case (if
> the control word hasn't been corrupted).  CMPXCHG8B is not applicable
> here because it's a read-only mapping.  Maybe add a comment at least
> about that “strong prevailing wind”?

There's read tearing in that case, which isn't super, but perhaps not
all together harmful.

Jason