linux-kernel - Re: [PATCH] block: sed-opal: Don't include <linux/kernel.h>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <798ce9ef-fb5e-012f-a016-8f39589e4e10@wanadoo.fr>
Date:   Mon, 5 Dec 2022 20:09:04 +0100
From:   Christophe JAILLET <christophe.jaillet@...adoo.fr>
To:     Christoph Hellwig <hch@...radead.org>
Cc:     Jonathan Derrick <jonathan.derrick@...ux.dev>,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
        linux-block@...r.kernel.org
Subject: Re: [PATCH] block: sed-opal: Don't include <linux/kernel.h>

Le 05/12/2022 à 08:10, Christoph Hellwig a écrit :
> On Sat, Dec 03, 2022 at 01:18:49PM +0100, Christophe JAILLET wrote:
>>   #include <uapi/linux/sed-opal.h>
>> -#include <linux/kernel.h>
>> +
>> +#include <linux/compiler_types.h>		/* for __user */
> 
> Not sure we really need the comment here, we don't comment on the
> other includes either.  Also why the added empty line?
> 

Ok for the comment, I'll remove it.
In header files, sometimes, when not obvious, we find such comments. 
Sometimes we don't.

For the empty line, it was mostly a matter of taste. My goal was to 
explicitly show that one was <uapi/linux, and the other one only <linux/

I'll remove it as well.

My main point, was only to remove kernel.h.

CJ