linux-kernel - Re: [PATCH] block: sed-opal: Don't include <linux/kernel.h>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y42ZV/AwSqUlDnas@infradead.org>
Date:   Sun, 4 Dec 2022 23:10:15 -0800
From:   Christoph Hellwig <hch@...radead.org>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc:     Jonathan Derrick <jonathan.derrick@...ux.dev>,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
        linux-block@...r.kernel.org
Subject: Re: [PATCH] block: sed-opal: Don't include <linux/kernel.h>

On Sat, Dec 03, 2022 at 01:18:49PM +0100, Christophe JAILLET wrote:
>  #include <uapi/linux/sed-opal.h>
> -#include <linux/kernel.h>
> +
> +#include <linux/compiler_types.h>		/* for __user */

Not sure we really need the comment here, we don't comment on the
other includes either.  Also why the added empty line?