[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20221205195728.GE15334@asutoshd-linux1.qualcomm.com>
Date: Mon, 5 Dec 2022 11:57:28 -0800
From: Asutosh Das <quic_asutoshd@...cinc.com>
To: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
CC: <martin.petersen@...cle.com>, <jejb@...ux.ibm.com>,
<andersson@...nel.org>, <vkoul@...nel.org>,
<quic_cang@...cinc.com>, <linux-arm-msm@...r.kernel.org>,
<linux-kernel@...r.kernel.org>, <linux-phy@...ts.infradead.org>,
<linux-scsi@...r.kernel.org>, <dmitry.baryshkov@...aro.org>,
<ahalaney@...hat.com>, <abel.vesa@...aro.org>,
<alim.akhtar@...sung.com>, <avri.altman@....com>,
<bvanassche@....org>
Subject: Re: [PATCH v4 16/23] scsi: ufs: ufs-qcom: Use dev_err_probe() for
printing probe error
On Thu, Dec 01 2022 at 09:45 -0800, Manivannan Sadhasivam wrote:
>Make use of dev_err_probe() for printing the probe error.
>
>Reviewed-by: Andrew Halaney <ahalaney@...hat.com>
>Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
>---
> drivers/ufs/host/ufs-qcom.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
Reviewed-by: Asutosh Das <quic_asutoshd@...cinc.com>
>diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c
>index 8bb0f4415f1a..38e2ed749d75 100644
>--- a/drivers/ufs/host/ufs-qcom.c
>+++ b/drivers/ufs/host/ufs-qcom.c
>@@ -1441,9 +1441,9 @@ static int ufs_qcom_probe(struct platform_device *pdev)
> /* Perform generic probe */
> err = ufshcd_pltfrm_init(pdev, &ufs_hba_qcom_vops);
> if (err)
>- dev_err(dev, "ufshcd_pltfrm_init() failed %d\n", err);
>+ return dev_err_probe(dev, err, "ufshcd_pltfrm_init() failed\n");
>
>- return err;
>+ return 0;
> }
>
> /**
>--
>2.25.1
>
Powered by blists - more mailing lists