[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20221205195942.GF15334@asutoshd-linux1.qualcomm.com>
Date: Mon, 5 Dec 2022 11:59:42 -0800
From: Asutosh Das <quic_asutoshd@...cinc.com>
To: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
CC: <martin.petersen@...cle.com>, <jejb@...ux.ibm.com>,
<andersson@...nel.org>, <vkoul@...nel.org>,
<quic_cang@...cinc.com>, <linux-arm-msm@...r.kernel.org>,
<linux-kernel@...r.kernel.org>, <linux-phy@...ts.infradead.org>,
<linux-scsi@...r.kernel.org>, <dmitry.baryshkov@...aro.org>,
<ahalaney@...hat.com>, <abel.vesa@...aro.org>,
<alim.akhtar@...sung.com>, <avri.altman@....com>,
<bvanassche@....org>
Subject: Re: [PATCH v4 17/23] scsi: ufs: ufs-qcom: Fix the Qcom register name
for offset 0xD0
On Thu, Dec 01 2022 at 09:45 -0800, Manivannan Sadhasivam wrote:
>On newer UFS revisions, the register at offset 0xD0 is called,
>REG_UFS_PARAM0. Since the existing register, RETRY_TIMER_REG is not used
>anywhere, it is safe to use the new name.
>
>Reviewed-by: Andrew Halaney <ahalaney@...hat.com>
>Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
>---
> drivers/ufs/host/ufs-qcom.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
Reviewed-by: Asutosh Das <quic_asutoshd@...cinc.com>
>diff --git a/drivers/ufs/host/ufs-qcom.h b/drivers/ufs/host/ufs-qcom.h
>index 9d96ac71b27f..7fe928b82753 100644
>--- a/drivers/ufs/host/ufs-qcom.h
>+++ b/drivers/ufs/host/ufs-qcom.h
>@@ -33,7 +33,8 @@ enum {
> REG_UFS_TX_SYMBOL_CLK_NS_US = 0xC4,
> REG_UFS_LOCAL_PORT_ID_REG = 0xC8,
> REG_UFS_PA_ERR_CODE = 0xCC,
>- REG_UFS_RETRY_TIMER_REG = 0xD0,
>+ /* On older UFS revisions, this register is called "RETRY_TIMER_REG" */
>+ REG_UFS_PARAM0 = 0xD0,
> REG_UFS_PA_LINK_STARTUP_TIMER = 0xD8,
> REG_UFS_CFG1 = 0xDC,
> REG_UFS_CFG2 = 0xE0,
>--
>2.25.1
>
Powered by blists - more mailing lists