lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <899d9d4c-36e8-6a4f-4243-dcf16f9ef29f@loongson.cn>
Date:   Mon, 5 Dec 2022 14:04:09 +0800
From:   Yinbo Zhu <zhuyinbo@...ngson.cn>
To:     Andy Shevchenko <andriy.shevchenko@...el.com>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        Bartosz Golaszewski <brgl@...ev.pl>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        WANG Xuerui <kernel@...0n.name>,
        Jiaxun Yang <jiaxun.yang@...goat.com>,
        Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
        Juxin Gao <gaojuxin@...ngson.cn>,
        Bibo Mao <maobibo@...ngson.cn>,
        Yanteng Si <siyanteng@...ngson.cn>, linux-gpio@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        loongarch@...ts.linux.dev, linux-mips@...r.kernel.org,
        Arnaud Patard <apatard@...driva.com>,
        Huacai Chen <chenhuacai@...nel.org>,
        Jianmin Lv <lvjianmin@...ngson.cn>,
        Hongchen Zhang <zhanghongchen@...ngson.cn>,
        Liu Peibao <liupeibao@...ngson.cn>
Subject: Re: [PATCH v10 1/2] gpio: loongson: add gpio driver support


在 2022/12/3 23:41, Andy Shevchenko 写道:
> On Sat, Dec 03, 2022 at 05:27:31PM +0200, Andy Shevchenko wrote:
>> On Sat, Dec 03, 2022 at 06:53:20PM +0800, Yinbo Zhu wrote:
>>> 在 2022/12/3 18:03, Linus Walleij 写道:
>>>> On Thu, Dec 1, 2022 at 1:33 PM Yinbo Zhu <zhuyinbo@...ngson.cn> wrote:
>>>>> +config GPIO_LOONGSON_64BIT
>>>>> +       tristate "Loongson 64 bit GPIO support"
>>>>> +       depends on LOONGARCH || COMPILE_TEST
>>>>> +       select GPIO_GENERIC
>>>>> +       select GPIOLIB_IRQCHIP
>>>> If the kernelbots start complaining you might need to add a:
>>>>
>>>> select IRQ_DOMAIN_HIERARCHY
>>>>
>>>> here.
>>> Bartosz had merged my patch and I will add a change on top of the existing
>>> series.
>> I don;'t know why he had done that, the driver requires a lot of cleanups,
>> e.g. why it uses acpi.h, what that "nice" container of the platform device for.

I just compile it that it is still okay when remove acpi.h, so I will 
remove it in v11.

and, I'm afraid I didn't catch your meaning about "

what that "nice" container of the platform device for."


you said is for following code ?
144         struct platform_device *pdev =
145                 container_of(chip->parent, struct platform_device, dev);

> + we have macros for get_direction() returned values and so on.
okay, I will use that macros in v11.

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ