linux-kernel - Re: [PATCH] trace: Fix some checker warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 05 Dec 2022 08:28:35 +0000
From:   David Howells <dhowells@...hat.com>
To:     Masami Hiramatsu (Google) <mhiramat@...nel.org>
Cc:     dhowells@...hat.com, rostedt@...dmis.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] trace: Fix some checker warnings

Masami Hiramatsu (Google) <mhiramat@...nel.org> wrote:

> > +#if defined(CONFIG_TRACER_MAX_TRACE) || defined(CONFIG_HWLAT_TRACER)
> >  static const struct file_operations tracing_max_lat_fops;
> > +#endif
> 
> Oops, I missed this part. Why did you introduced this #ifdefs?

Because:

    #if defined(CONFIG_TRACER_MAX_TRACE) || defined(CONFIG_HWLAT_TRACER)
    static const struct file_operations tracing_max_lat_fops = {

in the same file.  You get something like an unused symbol warning otherwise
if neither config option is defined.

David