linux-kernel - Re: [PATCH] trace: Fix some checker warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221204223308.22e63bac@rorschach.local.home>
Date:   Sun, 4 Dec 2022 22:33:08 -0500
From:   Steven Rostedt <rostedt@...dmis.org>
To:     "Masami Hiramatsu (Google)" <mhiramat@...nel.org>
Cc:     kernel test robot <lkp@...el.com>,
        David Howells <dhowells@...hat.com>,
        oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] trace: Fix some checker warnings

On Mon, 5 Dec 2022 12:29:48 +0900
Masami Hiramatsu (Google) <mhiramat@...nel.org> wrote:

> No, that including defined(CONFIG_FSNOTIFY) :)

Ah I missed that :-)

> 
> So it must be something like 
> 
>   #if defined(CONFIG_TRACER_MAX_TRACE) || defined(CONFIG_HWLAT_TRACER) \
>           || defined(CONFIG_OSNOISE_TRACER)
>   #define USE_MAX_TRACE_OPS
>   #endif
> 
>   #if defined(USE_MAX_TRACE_OPS) && defined(CONFIG_FSNOTIFY)
>   #define LATENCY_FS_NOTIFY
>   #endif
> 
> 
> But this introduces a hidden dependency which is not tracked by
> kconfig. So I think it is better to make those kconfig (non-menu)

Right, that could be done.

> items. (and the question came up, why can't those use (depend on)
> CONFIG_TRACER_MAX_TRACE instead of introducing the USE_MAX_TRACE_OPS.)

Probably just have OSNOISE and HWLAT select TRACER_MAX_TRACE and just
use that.

-- Steve