linux-kernel - Re: [PATCH] i2c-pxa2xx: fix missing pci_disable_device() on error in ce4100_i2c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y43BjGqsk+u/Nb+C@ninjato>
Date:   Mon, 5 Dec 2022 11:01:48 +0100
From:   Wolfram Sang <wsa@...nel.org>
To:     Hui Tang <tanghui20@...wei.com>
Cc:     linux-i2c@...r.kernel.org, linux@...ck-us.net, bence98@....bme.hu,
        linux-kernel@...r.kernel.org, weiyongjun1@...wei.com,
        yusongping@...wei.com
Subject: Re: [PATCH] i2c-pxa2xx: fix missing pci_disable_device() on error in
 ce4100_i2c_probe

On Mon, Nov 14, 2022 at 05:25:40PM +0800, Hui Tang wrote:
> Using pcim_enable_device() to avoid missing pci_disable_device().
> 
> Fixes: 7e94dd154e934 ("i2c-pxa2xx: Add PCI support for PXA I2C controller")
> Signed-off-by: Hui Tang <tanghui20@...wei.com>

Fixed the subject to "i2c: pxa-pci:" and fixed this checkpatch warning:

WARNING: Please use correct Fixes: style 'Fixes: <12 chars of sha1> ("<title line>")' - ie: 'Fixes: 7e94dd154e93 ("i2c-pxa2xx: Add PCI support for PXA I2C controller")'
#3: 
Fixes: 7e94dd154e934 ("i2c-pxa2xx: Add PCI support for PXA I2C controller")

Please do that in the future. After all that, applied to for-next, thanks!


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)