linux-kernel - Re: [PATCH 1/2] Documentation/features-refresh.sh: Only sed the beginning "arch" of ARCH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87k036mamt.fsf@meer.lwn.net>
Date:   Mon, 05 Dec 2022 03:02:18 -0700
From:   Jonathan Corbet <corbet@....net>
To:     Tiezhu Yang <yangtiezhu@...ngson.cn>
Cc:     loongarch@...ts.linux.dev, linux-doc@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] Documentation/features-refresh.sh: Only sed the
 beginning "arch" of ARCH_DIR

Tiezhu Yang <yangtiezhu@...ngson.cn> writes:

> It should only sed the beginning "arch" of ARCH_DIR in features-refresh.sh,
> otherwise loongarch is recognized as loong, that is not what we want.
>
> Fixes: be99f610a110 ("Documentation/features: Add script that refreshes the arch support status files in place")
> Signed-off-by: Tiezhu Yang <yangtiezhu@...ngson.cn>
> ---
>  Documentation/features/scripts/features-refresh.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/features/scripts/features-refresh.sh b/Documentation/features/scripts/features-refresh.sh
> index 9e72d38..c228812 100755
> --- a/Documentation/features/scripts/features-refresh.sh
> +++ b/Documentation/features/scripts/features-refresh.sh
> @@ -60,7 +60,7 @@ for F_FILE in Documentation/features/*/*/arch-support.txt; do
>  	echo "    |         arch |status|" >> $T_FILE
>  	echo "    -----------------------" >> $T_FILE
>  	for ARCH_DIR in arch/*/; do
> -		ARCH=$(echo $ARCH_DIR | sed -e 's/arch//g' | sed -e 's/\///g')
> +		ARCH=$(echo $ARCH_DIR | sed -e 's/^arch//g' | sed -e 's/\///g')

So ... looking at this now, it strikes me as a bit of a convoluted way
to reimplement "basename" - obviously incorrectly before this fix.  Oh
well, this is better than before, so I've applied the series.

Thanks,

jon