linux-kernel - Re: [linus:master] [KVM] 92e7d5c83a: kernel-selftests.kvm.triple_fault_event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y44rHsJU9OdkxCHA@google.com>
Date:   Mon, 5 Dec 2022 17:32:14 +0000
From:   Sean Christopherson <seanjc@...gle.com>
To:     kernel test robot <oliver.sang@...el.com>
Cc:     Maxim Levitsky <mlevitsk@...hat.com>, oe-lkp@...ts.linux.dev,
        lkp@...el.com, Paolo Bonzini <pbonzini@...hat.com>,
        linux-kernel@...r.kernel.org, kvm@...r.kernel.org,
        xudong.hao@...el.com
Subject: Re: [linus:master] [KVM]  92e7d5c83a:
 kernel-selftests.kvm.triple_fault_event_test.fail

On Sat, Dec 03, 2022, kernel test robot wrote:
> 
> Greeting,
> 
> FYI, we noticed kernel-selftests.kvm.triple_fault_event_test.fail due to commit (built with gcc-11):
> 
> commit: 92e7d5c83aff124f49082585e57939ed24b59c5c ("KVM: x86: allow L1 to not intercept triple fault")
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git master

Should already be fixed.  Thanks!

commit df0bb47baa95aad133820b149851d5b94cbc6790
Author: Paolo Bonzini <pbonzini@...hat.com>
Date:   Wed Nov 30 11:14:35 2022 -0500

    KVM: x86: fix uninitialized variable use on KVM_REQ_TRIPLE_FAULT
    
    If a triple fault was fixed by kvm_x86_ops.nested_ops->triple_fault (by
    turning it into a vmexit), there is no need to leave vcpu_enter_guest().
    Any vcpu->requests will be caught later before the actual vmentry,
    and in fact vcpu_enter_guest() was not initializing the "r" variable.
    Depending on the compiler's whims, this could cause the
    x86_64/triple_fault_event_test test to fail.
    
    Cc: Maxim Levitsky <mlevitsk@...hat.com>
    Fixes: 92e7d5c83aff ("KVM: x86: allow L1 to not intercept triple fault")
    Signed-off-by: Paolo Bonzini <pbonzini@...hat.com>