[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Y47msXHvtKVlzDu2@localhost.localdomain>
Date: Tue, 6 Dec 2022 09:52:33 +0300
From: Artem Chernyshev <artem.chernyshev@...-soft.ru>
To: Vishnu Dasa <vdasa@...are.com>
Cc: Stefano Garzarella <sgarzare@...hat.com>,
Pv-drivers <Pv-drivers@...are.com>,
Bryan Tan <bryantan@...are.com>,
Jakub Kicinski <kuba@...nel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
Linux Virtualization <virtualization@...ts.linux-foundation.org>,
"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
"lvc-project@...uxtesting.org" <lvc-project@...uxtesting.org>,
"David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH v3] net: vmw_vsock: vmci: Check memcpy_from_msg()
Hi,
On Mon, Dec 05, 2022 at 11:03:47PM +0000, Vishnu Dasa wrote:
>
> > On Dec 5, 2022, at 3:52 AM, Artem Chernyshev <artem.chernyshev@...-soft.ru> wrote:
> >
> > vmci_transport_dgram_enqueue() does not check the return value
> > of memcpy_from_msg(). Return with an error if the memcpy fails.
>
> I think we can add some more information in the description. Sorry, I
> should've said this earlier.
>
> vmci_transport_dgram_enqueue() does not check the return value
> of memcpy_from_msg(). If memcpy_from_msg() fails, it is possible that
> uninitialized memory contents are sent unintentionally instead of user's
> message in the datagram to the destination. Return with an error if
> memcpy_from_msg() fails.
>
> >
> > Found by Linux Verification Center (linuxtesting.org) with SVACE.
> >
> > Fixes: 0f7db23a07af ("vmci_transport: switch ->enqeue_dgram, ->enqueue_stream and ->dequeue_stream to msghdr")
> > Signed-off-by: Artem Chernyshev <artem.chernyshev@...-soft.ru>
>
> Thanks, Artem! This version looks good to me modulo my suggestion
> about the description above.
>
> Reviewed-by: Vishnu Dasa <vdasa@...are.com>
>
> Regards,
> Vishnu
>
No problem, I'll change description in v4
Thanks,
Artem
Powered by blists - more mailing lists