[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <df281b81-ba6c-4ca8-3da6-135d4ae09861@kernel.org>
Date: Tue, 6 Dec 2022 07:53:00 +0100
From: Jiri Slaby <jirislaby@...nel.org>
To: Ricardo Ribalda <ribalda@...omium.org>,
Jonathan Corbet <corbet@....net>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-serial@...r.kernel.org
Subject: Re: [PATCH v3 2/2] earlycon: Increase options size
On 24. 11. 22, 13:39, Ricardo Ribalda wrote:
> Now that the clock frequency is also part of the options, 16 bytes is
> too little.
>
> Without this patch dmesg does not show the whole options, Eg:
>
> earlycon: uart0 at MMIO32 0x00000000fedc9000 (options '115200n8,480000')
>
> instead of: '115200n8,48000000'
>
> Signed-off-by: Ricardo Ribalda <ribalda@...omium.org>
Reviewed-by: Jiri Slaby <jirislaby@...nel.org>
> diff --git a/include/linux/serial_core.h b/include/linux/serial_core.h
> index d657f2a42a7b..f555927195da 100644
> --- a/include/linux/serial_core.h
> +++ b/include/linux/serial_core.h
> @@ -701,7 +701,7 @@ static inline int uart_poll_timeout(struct uart_port *port)
> struct earlycon_device {
> struct console *con;
> struct uart_port port;
> - char options[16]; /* e.g., 115200n8 */
> + char options[32]; /* e.g., 115200n8 */
> unsigned int baud;
> };
>
>
--
js
suse labs
Powered by blists - more mailing lists