linux-kernel - Re: [PATCH v1 0/2] PM: sleep: Avoid using pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y477tlqofSqUpd8M@alley>
Date:   Tue, 6 Dec 2022 09:22:14 +0100
From:   Petr Mladek <pmladek@...e.com>
To:     "Rafael J. Wysocki" <rjw@...ysocki.net>
Cc:     Linux PM <linux-pm@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Thomas Weißschuh <linux@...ssschuh.net>,
        Lukas Bulwahn <lukas.bulwahn@...il.com>,
        Joe Perches <joe@...ches.com>,
        Todd Brandt <todd.e.brandt@...ux.intel.com>
Subject: Re: [PATCH v1 0/2] PM: sleep: Avoid using pr_cont() in tasks
 freezing code

On Thu 2022-12-01 19:31:59, Rafael J. Wysocki wrote:
> Hi All,
> 
> The first patch in this series rearranges the tasks freezing code used during
> system-wide suspend and hibernation to avoid printing continuation messages
> with pr_cont() which is problematic.
> 
> The second patch refines one more message in that code on top of the first one.

Both patches seems to do what they are supposed to do. Feel free to use:

Reviewed-by: Petr Mladek <pmladek@...e.com>

That said, I am not familiar with the freezer code. For example, I was
not aware of linux-pm/tools/power/pm-graph/sleepgraph.py. Anyway,
both changes make perfect sense and I do not see any problem.

Best Regards,
Petr