linux-kernel - Re: [PATCH] Linux: SPI: add Gigadevice part #

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221206091846.02f6396f@xps-13>
Date:   Tue, 6 Dec 2022 09:18:46 +0100
From:   Miquel Raynal <miquel.raynal@...tlin.com>
To:     Vlim <vlim@...adevice.com>
Cc:     Michael Walle <michael@...le.cc>,
        Victor Lim <victorswlim@...il.com>,
        "tudor.ambarus@...rochip.com" <tudor.ambarus@...rochip.com>,
        "p.yadav@...com" <p.yadav@...com>,
        "richard@....at" <richard@....at>,
        "vigneshr@...com" <vigneshr@...com>,
        "linux-mtd@...ts.infradead.org" <linux-mtd@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "vikhyat.goyal@....com" <vikhyat.goyal@....com>,
        "amit.kumar-mahapatra@....com" <amit.kumar-mahapatra@....com>,
        "alejandro.carmona@....com" <alejandro.carmona@....com>
Subject: Re: [PATCH] Linux: SPI: add Gigadevice part #

Hi Vlim,

vlim@...adevice.com wrote on Tue, 6 Dec 2022 01:27:13 +0000:

> Hi, Michael,
> 
> I will redo the patch following this doc.
> At the meantime, can you point out a few mistakes that I am making so that I can correct it in the next submit.

Here are a few:
- The title is wrong (git log --oneline <file> for hints)
- The commit log is useless
- Don't make unrelated changes in your commit, one change == one commit
- Don't change how the code looks like for no reason or justification

And please avoid top posting when answering.

Good luck!

Thanks,
Miquèl

> 
> ________________________________
> From: Michael Walle <michael@...le.cc>
> Sent: Monday, December 5, 2022 00:22
> To: Victor Lim <victorswlim@...il.com>
> Cc: tudor.ambarus@...rochip.com <tudor.ambarus@...rochip.com>; p.yadav@...com <p.yadav@...com>; miquel.raynal@...tlin.com <miquel.raynal@...tlin.com>; richard@....at <richard@....at>; vigneshr@...com <vigneshr@...com>; linux-mtd@...ts.infradead.org <linux-mtd@...ts.infradead.org>; linux-kernel@...r.kernel.org <linux-kernel@...r.kernel.org>; vikhyat.goyal@....com <vikhyat.goyal@....com>; amit.kumar-mahapatra@....com <amit.kumar-mahapatra@....com>; alejandro.carmona@....com <alejandro.carmona@....com>; Vlim <vlim@...adevice.com>
> Subject: Re: [PATCH] Linux: SPI: add Gigadevice part #
> 
> [You don't often get email from michael@...le.cc. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
> 
> 此为外部邮件，谨防钓鱼邮件，请注意邮件是否涉及敏感信息
> 
> This is an external email, beware of phishing emails. Please pay close attention to whether the email contains sensitive information
> 
> 
> Hi,
> 
> Am 2022-12-04 09:00, schrieb Victor Lim:
> > Edited gigadevice.c  
> 
> Please have a look at
> https://www.kernel.org/doc/html/latest/process/submitting-patches.html
> 
> -michael