linux-kernel - Re: [PATCH] Linux: SPI: add Gigadevice part #

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <208ffab6-a20b-c6f0-7ea7-cb258a7c894c@kontron.de>
Date:   Tue, 6 Dec 2022 12:37:02 +0100
From:   Frieder Schrempf <frieder.schrempf@...tron.de>
To:     Miquel Raynal <miquel.raynal@...tlin.com>,
        Vlim <vlim@...adevice.com>
Cc:     Michael Walle <michael@...le.cc>,
        Victor Lim <victorswlim@...il.com>,
        "tudor.ambarus@...rochip.com" <tudor.ambarus@...rochip.com>,
        "p.yadav@...com" <p.yadav@...com>,
        "richard@....at" <richard@....at>,
        "vigneshr@...com" <vigneshr@...com>,
        "linux-mtd@...ts.infradead.org" <linux-mtd@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "vikhyat.goyal@....com" <vikhyat.goyal@....com>,
        "amit.kumar-mahapatra@....com" <amit.kumar-mahapatra@....com>,
        "alejandro.carmona@....com" <alejandro.carmona@....com>
Subject: Re: [PATCH] Linux: SPI: add Gigadevice part #

On 06.12.22 09:18, Miquel Raynal wrote:
> Hi Vlim,
> 
> vlim@...adevice.com wrote on Tue, 6 Dec 2022 01:27:13 +0000:
> 
>> Hi, Michael,
>>
>> I will redo the patch following this doc.
>> At the meantime, can you point out a few mistakes that I am making so that I can correct it in the next submit.
> 
> Here are a few:
> - The title is wrong (git log --oneline <file> for hints)
> - The commit log is useless
> - Don't make unrelated changes in your commit, one change == one commit
> - Don't change how the code looks like for no reason or justification
> 
> And please avoid top posting when answering.

Here are some more:

* sending (almost) the same wrong patch again ignoring feedback from
maintainers
* not using version prefixes in your subject line (PATCH v2: ...)
* not adding a changelog to your patch
* keeping your replies off the mailing list (probably your @gigadevice
address is not subscribed!?)