linux-kernel - Re: Fw: [PATCH 0/2] feat: checkpatch: prohibit Buglink: and warn about missing Link:

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <11a9fe60f5333a931b8d75f67808b6d923c16dfa.camel@perches.com>
Date:   Mon, 05 Dec 2022 17:02:33 -0800
From:   Joe Perches <joe@...ches.com>
To:     Andrew Morton <akpm@...ux-foundation.org>,
        Kai Wasserbäch <kai@....carbon-project.org>
Cc:     Thorsten Leemhuis <linux@...mhuis.info>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: Fw: [PATCH 0/2] feat: checkpatch: prohibit Buglink: and warn
 about missing Link:

On Mon, 2022-12-05 at 13:14 -0800, Andrew Morton wrote:
> Apparently MAINTAINERS is hard to read.  Please review?
> 
> Thanks.
> 
> Begin forwarded message:
> 
> Date: Sun,  4 Dec 2022 12:33:37 +0100
> From: Kai Wasserbäch <kai@....carbon-project.org>
> To: linux-kernel@...r.kernel.org
> Cc: Andrew Morton <akpm@...ux-foundation.org>, Thorsten Leemhuis <linux@...mhuis.info>
> Subject: [PATCH 0/2] feat: checkpatch: prohibit Buglink: and warn about missing Link:
> 
> 
> Hey,
> Thorsten Leemhuis suggested the following two changes to checkpatch, which
> I hereby humbly submit for review. Please let me know if any changes
> would be required for acceptance.
> 
> NOTES:
> - checkpatch is rather long, so I might have chosen the wrong section to
>   add these two checks. Any better placement suggestion is welcome.
> - checkpatch implements custum versions of Perl core modules, that might
>   be an future area for clean-ups? Eg. right off the bat there is a
>   `uniq` implementation. List::Util (core module since 5.8.0 (5.7.3 to
>   be pedantic)) has a far better performing version in XS.

Maybe.  I don't know there are that many generic functions
that could be used.  You are welcome find some.

> 
> Cheers,
> Kai
> 
> Suggested-by: Thorsten Leemhuis <linux@...mhuis.info>
> Signed-off-by: Kai Wasserbäch <kai@....carbon-project.org>
> 
> 
> Kai Wasserbäch (2):
>   feat: checkpatch: error on usage of a Buglink tag in the commit log

Why, what's wrong with a buglink reference?

>   feat: checkpatch: Warn about Reported-by: not being followed by a
>     Link:

I think this is unnecessary.