linux-kernel - Re: [PATCH v3 1/9] blk-throttle: correct stale comment in throtl_pd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <dbec0c06-c1e0-5ee7-3b57-24a1d239026f@huaweicloud.com>
Date:   Tue, 6 Dec 2022 09:17:58 +0800
From:   Kemeng Shi <shikemeng@...weicloud.com>
To:     Jens Axboe <axboe@...nel.dk>, tj@...nel.org, josef@...icpanda.com
Cc:     cgroups@...r.kernel.org, linux-block@...r.kernel.org,
        linux-kernel@...r.kernel.org, shikemeng@...wei.com,
        linfeilong@...wei.com, liuzhiqiang26@...wei.com
Subject: Re: [PATCH v3 1/9] blk-throttle: correct stale comment in
 throtl_pd_init



on 12/6/2022 4:43 AM, Jens Axboe wrote:
> On 12/5/22 4:57?AM, Kemeng Shi wrote:
>> From: Kemeng Shi <shikemeng@...wei.com>
>>
>> On the default hierarchy (cgroup2), the throttle interface files don't
>> exist in the root cgroup, so the ablity to limit the whole system
>> by configuring root group is not existing anymore. In general, cgroup
>> doesn't wanna be in the business of restricting resources at the
>> system level, so correct the stale comment that we can limit whole
>> system to we can only limit subtree.
>>
>> Signed-off-by: Kemeng Shi <shikemeng@...wei.com>
>> Acked-by: Tejun Heo <tj@...nel.org>
>> Signed-off-by: Kemeng Shi <shikemeng@...weicloud.com>
> 
> Which one should be used? You have duplicate SOBs in each of the
> commits. It's marked as being from Kemeng Shi <shikemeng@...wei.com> so
> that is what I'll use.

Either one is great, thanks.

-- 
Best wishes
Kemeng Shi