linux-kernel - Re: [PATCH] vfio/ap/ccw/samples: Fix device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 6 Dec 2022 11:02:25 +0100
From:   Halil Pasic <pasic@...ux.ibm.com>
To:     Alex Williamson <alex.williamson@...hat.com>
Cc:     ruanjinjie <ruanjinjie@...wei.com>,
        Tony Krowiak <akrowiak@...ux.ibm.com>,
        Jason Herne <jjherne@...ux.ibm.com>,
        Kirti Wankhede <kwankhede@...dia.com>,
        Kevin Tian <kevin.tian@...el.com>,
        Eric Farman <farman@...ux.ibm.com>, kvm@...r.kernel.org,
        linux-kernel@...r.kernel.org, Halil Pasic <pasic@...ux.ibm.com>
Subject: Re: [PATCH] vfio/ap/ccw/samples: Fix device_register() unwind path

On Fri, 02 Dec 2022 09:46:15 -0700
Alex Williamson <alex.williamson@...hat.com> wrote:

> We always need to call put_device() if device_register() fails.
> All vfio drivers calling device_register() include a similar unwind
> stack via gotos, therefore split device_unregister() into its
> device_del() and put_device() components in the unwind path, and
> add a goto target to handle only the put_device() requirement.
> 
> Reported-by: Ruan Jinjie <ruanjinjie@...wei.com>
> Link: https://lore.kernel.org/all/20221118032827.3725190-1-ruanjinjie@huawei.com
> Fixes: d61fc96f47fd ("sample: vfio mdev display - host device")
> Fixes: 9d1a546c53b4 ("docs: Sample driver to demonstrate how to use Mediated device framework.")
> Fixes: a5e6e6505f38 ("sample: vfio bochs vbe display (host device for bochs-drm)")
> Fixes: 9e6f07cd1eaa ("vfio/ccw: create a parent struct")
> Fixes: 36360658eb5a ("s390: vfio_ap: link the vfio_ap devices to the vfio_ap bus subsystem")
> Cc: Tony Krowiak <akrowiak@...ux.ibm.com>
> Cc: Halil Pasic <pasic@...ux.ibm.com>
> Cc: Jason Herne <jjherne@...ux.ibm.com>
> Cc: Kirti Wankhede <kwankhede@...dia.com>
> Reviewed-by: Kevin Tian <kevin.tian@...el.com>
> Reviewed-by: Eric Farman <farman@...ux.ibm.com>
> Signed-off-by: Alex Williamson <alex.williamson@...hat.com>

Reviewed-by: Halil Pasic <pasic@...ux.ibm.com>